-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'just-the-docs' theme for GitHub pages. #79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romoh
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The github workflow is broken.
I think you need to switch to different github actions to deploy the new theme.
cwize1
force-pushed
the
user/chrisgun/docstheme
branch
from
January 10, 2025 20:11
10c38e2
to
dcda35f
Compare
romoh
previously approved these changes
Jan 11, 2025
Replace the GitHub pages Jekyll theme with 'just-the-docs'. This theme has an inbuilt navigation bar. It also seems to have good browser width handling. In addition, add a Gemfile and Makefile for the docs generation.
cwize1
force-pushed
the
user/chrisgun/docstheme
branch
from
January 13, 2025 23:33
6ad1a29
to
949d3fe
Compare
romoh
reviewed
Jan 14, 2025
romoh
approved these changes
Jan 14, 2025
elainezhao1
pushed a commit
that referenced
this pull request
Jan 23, 2025
Replace the GitHub pages Jekyll theme with 'just-the-docs'. This theme has an inbuilt navigation bar. It also seems to have good browser width handling. In addition, add a Gemfile and Makefile for the docs generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the GitHub pages Jekyll theme with 'just-the-docs'. This theme has an inbuilt navigation bar. It also seems to have good browser width handling.
In addition, add a Gemfile and Makefile for the docs generation.
Checklist