Better handle filesystem optional features. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liulanze
reviewed
Jan 7, 2025
liulanze
previously approved these changes
Jan 8, 2025
PawelWMS
reviewed
Jan 8, 2025
PawelWMS
reviewed
Jan 8, 2025
PawelWMS
reviewed
Jan 8, 2025
mfrw
reviewed
Jan 9, 2025
Filesystems (e.g. ext4, xfs) sometimes receive new features. When these features are enabled, anything that loads the filesystem (e.g. kernel, grub, etc.) must support the new feature or it will refuse to load it. When formatting a new partition, there are a few considerations for if a filesystem feature should be enabled: - Does the version of mkfs support that feature? - Does the build host kernel support that feature? - Does the target OS support that feature? This change ensure that all these considerations are handled correctly for the ext4 and xfs filesystem types.
cwize1
force-pushed
the
user/chrisgun/xfsOptions
branch
from
e0cb1c4 to
37f090a
Compare
amritakohli
reviewed
Jan 10, 2025
romoh
approved these changes
Jan 10, 2025
elainezhao1
pushed a commit
that referenced
this pull request
Jan 23, 2025
Filesystems (e.g. ext4, xfs) sometimes receive new features. When these features are enabled, anything that loads the filesystem (e.g. kernel, grub, etc.) must support the new feature or it will refuse to load it. When formatting a new partition, there are a few considerations for if a filesystem feature should be enabled: - Does the version of mkfs support that feature? - Does the build host kernel support that feature? - Does the target OS support that feature? This change ensure that all these considerations are handled correctly for the ext4 and xfs filesystem types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filesystems (e.g. ext4, xfs) sometimes receive new features. When these features are enabled, anything that loads the filesystem (e.g. kernel, grub, etc.) must support the new feature or it will refuse to load it.
When formatting a new partition, there are a few considerations for if a filesystem feature should be enabled:
This change ensure that all these considerations are handled correctly for the ext4 and xfs filesystem types.
Checklist