Add Azure Linux base image API. #483
Conversation
Add API that allows an Azure Linux image to be specified as a base] image. This is mostly just syntactic sugar around the OCI API except that the OCI artifact's signature is checked against the known Azure Linux Certificate Authority.
toolkit/tools/pkg/imagecustomizerlib/downloadimageazurelinux.go
Outdated
Show resolved
Hide resolved
toolkit/tools/pkg/imagecustomizerlib/downloadimageazurelinux.go
Outdated
Show resolved
Hide resolved
| CertificateFsPath string | ||
| } | ||
|
|
||
| func checkNotationSignature(ctx context.Context, buildDir string, remoteRepo *remote.Repository, |
There was a problem hiding this comment.
Could we consider updating this function to reuse subfunctions and improve readability?
There was a problem hiding this comment.
I don't understand. I don't believe there is any duplicated code in this function.
There was a problem hiding this comment.
The current implementation is all inline, but I think breaking it down could make it clearer. Could you try refactoring it into smaller subfunctions?
| ancestor: Image Customizer | ||
| --- | ||
|
|
||
| # azureLinuxImage type |
There was a problem hiding this comment.
do we expect customers to always use azureLinuxImage if they are using AZL images ? when should one use OCI image type
There was a problem hiding this comment.
Customers should use the dedicated API. The OCI is a generic API that can be used for debug (e.g. private ACR) and/or with other distros.
There was a problem hiding this comment.
Should we add a note in the OCI documentation mentioning that there is a dedicated azureLinuxImage API and provide a link to it?
3 participants
Add API that allows an Azure Linux image to be specified as a base] image. This is mostly just syntactic sugar around the OCI API except that the OCI artifact's signature is checked against the known Azure Linux Certificate Authority.
Checklist