-
Couldn't load subscription status.
- Fork 9
Improve SELinux Mode Detection with Enhanced GRUB Fallback Logic #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
himaja-kesari
wants to merge
7
commits into
main
Choose a base branch
from
user/himajakesari/fedora-grub-selinux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwize1
requested changes
Oct 20, 2025
cwize1
requested changes
Oct 22, 2025
cwize1
reviewed
Oct 22, 2025
cwize1
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the SELinux mode detection in BootCustomizer by implementing robust fallback logic between GRUB configuration variables and providing comprehensive error reporting. The changes improve reliability when detecting SELinux configuration in different GRUB setups, particularly for Fedora distributions.
Problem:
The existing SELinux mode detection logic in getSELinuxModeFromGrub() was fragile and could fail when:
GRUB_CMDLINE_LINUX variable was not present in grub
Only GRUB_CMDLINE_LINUX_DEFAULT contained the SELinux configuration
changes made :
Try to extract SELinux args from GRUB_CMDLINE_LINUX (higher priority) and also GRUB_CMDLINE_LINUX_DEFAULT
Enhanced error reporting: Capture and report both errors if both attempts fail
Checklist