UKI: Optimize kernel-to-initramfs mapping #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwize1
requested changes
Aug 28, 2025
liulanze
force-pushed
the
user/lanzeliu/uki-optimization-1
branch
from
784461f to
8c0f9ae
Compare
| BootDir = "boot" | ||
| EspDir = "boot/efi" | ||
| DefaultGrubCfgPath = "grub2/grub.cfg" | ||
| UkiKernelInfoJson = "uki-kernel-info.json" |
There was a problem hiding this comment.
some of these constants are only used in this file, unexport them ?
| var ukiNamePattern = regexp.MustCompile(`^vmlinuz-(.+)\.efi$`) | ||
|
|
||
| // UkiKernelInfo holds both command line arguments and initramfs name for a UKI kernel | ||
| type UkiKernelInfo struct { |
There was a problem hiding this comment.
change to ukiKernelInfo as its only being used in this file, see my comment above.
cwize1
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the UKI (Unified Kernel Image) build process by eliminating redundant calls to
getKernelToInitramfsMap()and consolidating kernel information into a single, well-structured data format.In addition, resolved the comment of "Use GrubArgsToString to convert args list to a string."
Before:
{ "vmlinuz-6.6.51.1-5.azl3": "console=tty0 console=ttyS0 ..." }After:
{ "vmlinuz-6.6.51.1-5.azl3": { "cmdline": "console=tty0 console=ttyS0 ...", "initramfs": "initramfs-6.6.51.1-5.azl3.img" } }Checklist