-
Notifications
You must be signed in to change notification settings - Fork 7
Keep systemd-ukify as an installed package in arm64 imagecustomizer container #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -97,8 +97,8 @@ touch "${containerStagingFolder}"/.mariner-toolkit-ignore-dockerenv | |||
|
|||
# azl doesn't support grub2-pc for arm64, hence remove it from dockerfile | |||
if [ "$ARCH" == "arm64" ]; then | |||
echo "Removing grub2-pc and systemd-ukify from Dockerfile for arm64" | |||
sed -i 's/\<grub2-pc systemd-ukify\>//g' "$dockerFile" | |||
echo "Removing grub2-pc from Dockerfile for arm64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A similar change is needed in the tests-functional.yml workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the golden container code being added by @liulanze
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But please wait until the RPM is published on PMC.
@cwize1 systemd-ukify is now available on PMC for aarch64. I think we are good to go? @liulanze @vinceaperri have golden container changes been merged? Does this PR need to add changes there as well? |
You are good to merge. The Dockerfile and RPM spec will need to be updated in azurelinux. But we can do that fix when the next release is consumed by azurelinux. |
In anticipation of the upcoming aarch64 systemd-ukify and systemd-boot package releases
See: microsoft/azurelinux#14449
Checklist