Skip to content

Conversation

SeanDougherty
Copy link
Contributor

@SeanDougherty SeanDougherty commented Aug 18, 2025

In anticipation of the upcoming aarch64 systemd-ukify and systemd-boot package releases

See: microsoft/azurelinux#14449


Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • Code conforms to style guidelines

@SeanDougherty SeanDougherty requested a review from a team as a code owner August 18, 2025 17:43
@@ -97,8 +97,8 @@ touch "${containerStagingFolder}"/.mariner-toolkit-ignore-dockerenv

# azl doesn't support grub2-pc for arm64, hence remove it from dockerfile
if [ "$ARCH" == "arm64" ]; then
echo "Removing grub2-pc and systemd-ukify from Dockerfile for arm64"
sed -i 's/\<grub2-pc systemd-ukify\>//g' "$dockerFile"
echo "Removing grub2-pc from Dockerfile for arm64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A similar change is needed in the tests-functional.yml workflow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the golden container code being added by @liulanze

cwize1
cwize1 previously approved these changes Aug 18, 2025
Copy link
Contributor

@cwize1 cwize1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But please wait until the RPM is published on PMC.

@SeanDougherty
Copy link
Contributor Author

@cwize1 systemd-ukify is now available on PMC for aarch64. I think we are good to go?

@liulanze @vinceaperri have golden container changes been merged? Does this PR need to add changes there as well?

@cwize1
Copy link
Contributor

cwize1 commented Sep 4, 2025

@cwize1 systemd-ukify is now available on PMC for aarch64. I think we are good to go?

@liulanze @vinceaperri have golden container changes been merged? Does this PR need to add changes there as well?

You are good to merge.

The Dockerfile and RPM spec will need to be updated in azurelinux. But we can do that fix when the next release is consumed by azurelinux.

@SeanDougherty SeanDougherty merged commit 1323114 into main Sep 4, 2025
23 checks passed
@SeanDougherty SeanDougherty deleted the user/sdougherty/container-uki-arm64 branch September 4, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants