Skip to content

Re-fix formatting of date-time parameters #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Re-fix formatting of date-time parameters #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions autorust/codegen/src/codegen_operations/set_request_param_code.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ impl ToTokens for SetRequestParamsCode {
quote! {
req.url_mut().query_pairs_mut().append_pair(#param_name, #param_name_var);
}
} else if param.type_name.is_date_time() {
quote! {
let formatted_date_time = crate::date_time::format_date_time(#param_name_var)?;
req.url_mut().query_pairs_mut().append_pair(#param_name, &formatted_date_time);
}
} else {
quote! {
req.url_mut().query_pairs_mut().append_pair(#param_name, &#param_name_var.to_string());
Expand Down
14 changes: 10 additions & 4 deletions azure_devops_rust_api/src/audit/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,14 +434,17 @@ pub mod audit_log {
);
}
if let Some(start_time) = &this.start_time {
let formatted_date_time =
crate::date_time::format_date_time(start_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("startTime", &start_time.to_string());
.append_pair("startTime", &formatted_date_time);
}
if let Some(end_time) = &this.end_time {
let formatted_date_time = crate::date_time::format_date_time(end_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("endTime", &end_time.to_string());
.append_pair("endTime", &formatted_date_time);
}
if let Some(batch_size) = &this.batch_size {
req.url_mut()
Expand Down Expand Up @@ -624,14 +627,17 @@ pub mod download_log {
.query_pairs_mut()
.append_pair("format", format);
if let Some(start_time) = &this.start_time {
let formatted_date_time =
crate::date_time::format_date_time(start_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("startTime", &start_time.to_string());
.append_pair("startTime", &formatted_date_time);
}
if let Some(end_time) = &this.end_time {
let formatted_date_time = crate::date_time::format_date_time(end_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("endTime", &end_time.to_string());
.append_pair("endTime", &formatted_date_time);
}
let req_body = azure_core::Bytes::new();
req.set_body(req_body);
Expand Down
34 changes: 25 additions & 9 deletions azure_devops_rust_api/src/build/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3654,14 +3654,16 @@ pub mod builds {
.append_pair("buildNumber", build_number);
}
if let Some(min_time) = &this.min_time {
let formatted_date_time = crate::date_time::format_date_time(min_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("minTime", &min_time.to_string());
.append_pair("minTime", &formatted_date_time);
}
if let Some(max_time) = &this.max_time {
let formatted_date_time = crate::date_time::format_date_time(max_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("maxTime", &max_time.to_string());
.append_pair("maxTime", &formatted_date_time);
}
if let Some(requested_for) = &this.requested_for {
req.url_mut()
Expand Down Expand Up @@ -9167,9 +9169,11 @@ pub mod definitions {
.append_pair("continuationToken", continuation_token);
}
if let Some(min_metrics_time) = &this.min_metrics_time {
let formatted_date_time =
crate::date_time::format_date_time(min_metrics_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("minMetricsTime", &min_metrics_time.to_string());
.append_pair("minMetricsTime", &formatted_date_time);
}
if let Some(definition_ids) = &this.definition_ids {
req.url_mut()
Expand All @@ -9180,14 +9184,18 @@ pub mod definitions {
req.url_mut().query_pairs_mut().append_pair("path", path);
}
if let Some(built_after) = &this.built_after {
let formatted_date_time =
crate::date_time::format_date_time(built_after)?;
req.url_mut()
.query_pairs_mut()
.append_pair("builtAfter", &built_after.to_string());
.append_pair("builtAfter", &formatted_date_time);
}
if let Some(not_built_after) = &this.not_built_after {
let formatted_date_time =
crate::date_time::format_date_time(not_built_after)?;
req.url_mut()
.query_pairs_mut()
.append_pair("notBuiltAfter", &not_built_after.to_string());
.append_pair("notBuiltAfter", &formatted_date_time);
}
if let Some(include_all_properties) = &this.include_all_properties {
req.url_mut().query_pairs_mut().append_pair(
Expand Down Expand Up @@ -9525,9 +9533,11 @@ pub mod definitions {
.append_pair("revision", &revision.to_string());
}
if let Some(min_metrics_time) = &this.min_metrics_time {
let formatted_date_time =
crate::date_time::format_date_time(min_metrics_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("minMetricsTime", &min_metrics_time.to_string());
.append_pair("minMetricsTime", &formatted_date_time);
}
if let Some(property_filters) = &this.property_filters {
req.url_mut()
Expand Down Expand Up @@ -10255,9 +10265,11 @@ pub mod metrics {
);
}
if let Some(min_metrics_time) = &this.min_metrics_time {
let formatted_date_time =
crate::date_time::format_date_time(min_metrics_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("minMetricsTime", &min_metrics_time.to_string());
.append_pair("minMetricsTime", &formatted_date_time);
}
let req_body = azure_core::Bytes::new();
req.set_body(req_body);
Expand Down Expand Up @@ -10394,9 +10406,11 @@ pub mod metrics {
);
}
if let Some(min_metrics_time) = &this.min_metrics_time {
let formatted_date_time =
crate::date_time::format_date_time(min_metrics_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("minMetricsTime", &min_metrics_time.to_string());
.append_pair("minMetricsTime", &formatted_date_time);
}
let req_body = azure_core::Bytes::new();
req.set_body(req_body);
Expand Down Expand Up @@ -10889,9 +10903,11 @@ pub mod yaml {
.append_pair("revision", &revision.to_string());
}
if let Some(min_metrics_time) = &this.min_metrics_time {
let formatted_date_time =
crate::date_time::format_date_time(min_metrics_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("minMetricsTime", &min_metrics_time.to_string());
.append_pair("minMetricsTime", &formatted_date_time);
}
if let Some(property_filters) = &this.property_filters {
req.url_mut()
Expand Down
4 changes: 3 additions & 1 deletion azure_devops_rust_api/src/distributed_task/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9452,9 +9452,11 @@ pub mod taskgroups {
.append_pair("$top", &top.to_string());
}
if let Some(continuation_token) = &this.continuation_token {
let formatted_date_time =
crate::date_time::format_date_time(continuation_token)?;
req.url_mut()
.query_pairs_mut()
.append_pair("continuationToken", &continuation_token.to_string());
.append_pair("continuationToken", &formatted_date_time);
}
if let Some(query_order) = &this.query_order {
req.url_mut()
Expand Down
54 changes: 30 additions & 24 deletions azure_devops_rust_api/src/git/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5344,16 +5344,18 @@ pub mod pull_requests {
);
}
if let Some(search_criteria_max_time) = &this.search_criteria_max_time {
req.url_mut().query_pairs_mut().append_pair(
"searchCriteria.maxTime",
&search_criteria_max_time.to_string(),
);
let formatted_date_time =
crate::date_time::format_date_time(search_criteria_max_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("searchCriteria.maxTime", &formatted_date_time);
}
if let Some(search_criteria_min_time) = &this.search_criteria_min_time {
req.url_mut().query_pairs_mut().append_pair(
"searchCriteria.minTime",
&search_criteria_min_time.to_string(),
);
let formatted_date_time =
crate::date_time::format_date_time(search_criteria_min_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("searchCriteria.minTime", &formatted_date_time);
}
if let Some(search_criteria_query_time_range_type) =
&this.search_criteria_query_time_range_type
Expand Down Expand Up @@ -5804,16 +5806,18 @@ pub mod pull_requests {
);
}
if let Some(search_criteria_max_time) = &this.search_criteria_max_time {
req.url_mut().query_pairs_mut().append_pair(
"searchCriteria.maxTime",
&search_criteria_max_time.to_string(),
);
let formatted_date_time =
crate::date_time::format_date_time(search_criteria_max_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("searchCriteria.maxTime", &formatted_date_time);
}
if let Some(search_criteria_min_time) = &this.search_criteria_min_time {
req.url_mut().query_pairs_mut().append_pair(
"searchCriteria.minTime",
&search_criteria_min_time.to_string(),
);
let formatted_date_time =
crate::date_time::format_date_time(search_criteria_min_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("searchCriteria.minTime", &formatted_date_time);
}
if let Some(search_criteria_query_time_range_type) =
&this.search_criteria_query_time_range_type
Expand Down Expand Up @@ -16617,10 +16621,11 @@ pub mod pushes {
.append_pair("$top", &top.to_string());
}
if let Some(search_criteria_from_date) = &this.search_criteria_from_date {
req.url_mut().query_pairs_mut().append_pair(
"searchCriteria.fromDate",
&search_criteria_from_date.to_string(),
);
let formatted_date_time =
crate::date_time::format_date_time(search_criteria_from_date)?;
req.url_mut()
.query_pairs_mut()
.append_pair("searchCriteria.fromDate", &formatted_date_time);
}
if let Some(search_criteria_include_links) =
&this.search_criteria_include_links
Expand Down Expand Up @@ -16649,10 +16654,11 @@ pub mod pushes {
.append_pair("searchCriteria.refName", search_criteria_ref_name);
}
if let Some(search_criteria_to_date) = &this.search_criteria_to_date {
req.url_mut().query_pairs_mut().append_pair(
"searchCriteria.toDate",
&search_criteria_to_date.to_string(),
);
let formatted_date_time =
crate::date_time::format_date_time(search_criteria_to_date)?;
req.url_mut()
.query_pairs_mut()
.append_pair("searchCriteria.toDate", &formatted_date_time);
}
let req_body = azure_core::Bytes::new();
req.set_body(req_body);
Expand Down
24 changes: 18 additions & 6 deletions azure_devops_rust_api/src/release/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,14 +820,18 @@ pub mod releases {
);
}
if let Some(min_created_time) = &this.min_created_time {
let formatted_date_time =
crate::date_time::format_date_time(min_created_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("minCreatedTime", &min_created_time.to_string());
.append_pair("minCreatedTime", &formatted_date_time);
}
if let Some(max_created_time) = &this.max_created_time {
let formatted_date_time =
crate::date_time::format_date_time(max_created_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("maxCreatedTime", &max_created_time.to_string());
.append_pair("maxCreatedTime", &formatted_date_time);
}
if let Some(query_order) = &this.query_order {
req.url_mut()
Expand Down Expand Up @@ -3808,14 +3812,18 @@ pub mod deployments {
.append_pair("createdBy", created_by);
}
if let Some(min_modified_time) = &this.min_modified_time {
let formatted_date_time =
crate::date_time::format_date_time(min_modified_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("minModifiedTime", &min_modified_time.to_string());
.append_pair("minModifiedTime", &formatted_date_time);
}
if let Some(max_modified_time) = &this.max_modified_time {
let formatted_date_time =
crate::date_time::format_date_time(max_modified_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("maxModifiedTime", &max_modified_time.to_string());
.append_pair("maxModifiedTime", &formatted_date_time);
}
if let Some(deployment_status) = &this.deployment_status {
req.url_mut()
Expand Down Expand Up @@ -3854,14 +3862,18 @@ pub mod deployments {
.append_pair("createdFor", created_for);
}
if let Some(min_started_time) = &this.min_started_time {
let formatted_date_time =
crate::date_time::format_date_time(min_started_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("minStartedTime", &min_started_time.to_string());
.append_pair("minStartedTime", &formatted_date_time);
}
if let Some(max_started_time) = &this.max_started_time {
let formatted_date_time =
crate::date_time::format_date_time(max_started_time)?;
req.url_mut()
.query_pairs_mut()
.append_pair("maxStartedTime", &max_started_time.to_string());
.append_pair("maxStartedTime", &formatted_date_time);
}
if let Some(source_branch) = &this.source_branch {
req.url_mut()
Expand Down
Loading