abupdate: use slot-*.addon.efi verbatim instead of verity*.addon.efi, add acl.slot - #64
Merged
bfjelds (bfjelds) merged 2 commits intoAug 28, 2026
Conversation
…l.slot cmdline Rename the per-slot verity addon templates from verity-a/b.addon.efi to slot-a/b.addon.efi, and install the active slot addon verbatim (no rename) into the .extra.d directory. Add acl.slot=<a|b> to each slot cmdline so the running kernel can identify its active slot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bfjelds (bfjelds)
marked this pull request as draft
August 28, 2026 20:21
bfjelds (bfjelds)
changed the title
There was a problem hiding this comment.
Pull request overview
Renames slot-specific UKI addons and embeds the active ACL slot in their command lines.
Changes:
- Renames verity addons to
slot-{a|b}.addon.efi. - Adds
acl.slot={a|b}. - Activates slot A using its template filename verbatim.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Address Copilot review feedback on PR 64: slot-a.addon.efi/ looked like a directory path due to a stray trailing slash. Replaced with a comma so it reads as two alternative addon filenames. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bfjelds (bfjelds)
marked this pull request as ready for review
August 28, 2026 22:13
bfjelds (bfjelds)
merged commit Aug 28, 2026
8a450f2
into
user/bfjelds/ab-verity-partuuid-uki-addons-20260708
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename ACL slot-based uki addons from
verity-{a|b}.addon.efitoslot-{a|b}.addon.efiand addacl.slot={a|b}.Validated with trident's pr-e2e + acldevel