-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rysweet 5207 net runtime interface to match python add registration to interface and inmemoryruntime #5215
Conversation
…ant serialize them.
…python---add-registration-to-interface-and-inmemoryruntime
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5215 +/- ##
=======================================
Coverage 70.08% 70.08%
=======================================
Files 179 179
Lines 11619 11619
=======================================
Hits 8143 8143
Misses 3476 3476
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 12 out of 27 changed files in this pull request and generated 5 comments.
Files not reviewed (15)
- dotnet/.editorconfig: Language not supported
- dotnet/samples/Hello/HelloAgent/registry.json: Language not supported
- dotnet/src/Microsoft.AutoGen/Core/IAgentRuntime.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Contracts/IAgent.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Runtime.Grpc/Abstractions/IGatewayRegistry.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Runtime.Grpc/Abstractions/IRegistryGrain.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Runtime.Grpc/Services/Grpc/GrpcGateway.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Core.Grpc/GrpcAgentRuntime.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Core/UninitializedAgentWorker.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Core/HostBuilderExtensions.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Core/Agent.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Core.Grpc/GrpcAgentWorkerHostBuilderExtension.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Core/AgentRuntime.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Core/AgentRuntimeBase.cs: Evaluated as low risk
- dotnet/src/Microsoft.AutoGen/Contracts/IRegistry.cs: Evaluated as low risk
Comments suppressed due to low confidence (5)
dotnet/src/Microsoft.AutoGen/Core/Registry.cs:41
- The use of '[]' to initialize collections is not valid C# syntax. It should be corrected to 'new List()'.
agents.AddRange(eventHandlingAgents.ToList());
dotnet/src/Microsoft.AutoGen/Core/Registry.cs:45
- The use of '[]' to initialize collections is not valid C# syntax. It should be corrected to 'new List()'.
agents.AddRange(combo.ToList());
dotnet/src/Microsoft.AutoGen/Core/Registry.cs:57
- The use of '[]' to initialize collections is not valid C# syntax. It should be corrected to 'new List()'.
agents.Add(agentType);
dotnet/src/Microsoft.AutoGen/Core/Registry.cs:106
- The method 'WriteStateAsync' should be awaited to ensure proper async operation.
return await WriteStateAsync(State, cancellationToken).ConfigureAwait(false);
dotnet/src/Microsoft.AutoGen/Contracts/IAgentRuntime.cs:33
- The method RuntimeSendRequestAsync has a comment indicating it will be removed in favor of send_message. This is confusing and should be clarified or removed.
ValueTask RuntimeSendRequestAsync(IAgent agent, RpcRequest request, CancellationToken cancellationToken = default);
Why are these changes needed?
Bringing the .NET more in line with the python
Related issue number
close #5207
Checks