Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl register and add sub RPC #5191

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Impl register and add sub RPC #5191

merged 8 commits into from
Jan 24, 2025

Conversation

jackgerrits
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70.08%. Comparing base (db2410c) to head (f750682).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ext/runtimes/grpc/_worker_runtime_host_servicer.py 66.66% 17 Missing ⚠️
...utogen-ext/src/autogen_ext/runtimes/grpc/_utils.py 82.60% 4 Missing ⚠️
...t/src/autogen_ext/runtimes/grpc/_worker_runtime.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5191      +/-   ##
==========================================
- Coverage   70.42%   70.08%   -0.34%     
==========================================
  Files         178      179       +1     
  Lines       11581    11620      +39     
==========================================
- Hits         8156     8144      -12     
- Misses       3425     3476      +51     
Flag Coverage Δ
unittests 70.08% <77.77%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how right now the non-messaging APIs are separate from messaging API. It is much cleaner that way.

@jackgerrits jackgerrits merged commit 55e929d into main Jan 24, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants