Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Normalize openai client stop reason to make more robust #5027

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

jackgerrits
Copy link
Member

Closes #5020
Closes #4875

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.49%. Comparing base (a7c97db) to head (4042989).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...xt/src/autogen_ext/models/openai/_openai_client.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5027      +/-   ##
==========================================
- Coverage   72.22%   68.49%   -3.73%     
==========================================
  Files         112      156      +44     
  Lines        6563    10129    +3566     
==========================================
+ Hits         4740     6938    +2198     
- Misses       1823     3191    +1368     
Flag Coverage Δ
unittests 68.49% <80.00%> (-3.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackgerrits jackgerrits added this to the 0.4.1 milestone Jan 13, 2025
@jackgerrits jackgerrits changed the title Normalize openai client stop reason to make more robust fix: Normalize openai client stop reason to make more robust Jan 13, 2025
@jackgerrits jackgerrits enabled auto-merge (squash) January 13, 2025 18:23
@jackgerrits jackgerrits merged commit c0082dd into main Jan 13, 2025
61 checks passed
@jackgerrits jackgerrits deleted the normalize_stop_reason branch January 28, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants