Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable output usage stat summary in Console as the stats is often inaccurate. #5021

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Jan 13, 2025

The stats accuracy must be resolved before we make it a default to display them.

This should go together with the patch to fix m1 console input.

@ekzhu ekzhu requested review from jackgerrits and afourney January 13, 2025 07:02
@ekzhu ekzhu changed the title Disable output stats in Console as the stats is often inaccurate. Disable output usage stat summary in Console as the stats is often inaccurate. Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.57%. Comparing base (a9c19d6) to head (77c1398).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5021      +/-   ##
==========================================
- Coverage   68.61%   68.57%   -0.04%     
==========================================
  Files         156      156              
  Lines       10053    10053              
==========================================
- Hits         6898     6894       -4     
- Misses       3155     3159       +4     
Flag Coverage Δ
unittests 68.57% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu enabled auto-merge (squash) January 13, 2025 07:06
@ekzhu ekzhu merged commit 23c9b78 into main Jan 13, 2025
61 checks passed
@ekzhu ekzhu deleted the disable-stats branch January 13, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants