-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make termination condition config declarative #4984
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4984 +/- ##
==========================================
+ Coverage 68.53% 68.86% +0.33%
==========================================
Files 156 156
Lines 10140 10252 +112
==========================================
+ Hits 6949 7060 +111
- Misses 3191 3192 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
python/packages/autogen-agentchat/src/autogen_agentchat/base/_termination.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just to make sure, we will use the override for a cleaner provider path right?
Why are these changes needed?
Step 1 in making components in agentchat natively declarative.
Results
Related issue number
Closes #4983
Checks