Improve message error when docker isn't running (#3816) #4600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When docker is not running and the user tries to use
DockerCommandLineCodeExecutort
he displayed error is:which is indeed not very helpful.
I initially searched for a built-in method in the
docker
library to determine whether the Docker daemon is running, but unfortunately, there’s none.The next issue is that there isn’t a specific exception that exclusively covers the scenario where the daemon is not running. Hence, we rely on catching the
DockerException
, which seems to encompass this case and potentially others.Because of this, I’m raising the custom message
“Please ensure Docker is installed and running”
only if the string“FileNotFoundError”
is in the error message.If this string is not in
e
, then I raise the error as usual, ensuring the user receives appropriate feedback based on the specific scenario.Related issue number
#3816
Checks