cli: support YAML as alternative config format#15517
Closed
maxtorqs wants to merge 1 commit intomicrosoft:mainfrom
Closed
cli: support YAML as alternative config format#15517maxtorqs wants to merge 1 commit intomicrosoft:mainfrom
maxtorqs wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Add aspire.config.yaml/.yml as alternatives to aspire.config.json. YAML is parsed via YamlDotNet's AOT-safe event-based API, converted to JSON, then deserialized through the existing source-gen pipeline. Save preserves the source format. Errors if multiple formats exist. Closes microsoft#15508
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15517Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15517" |
Member
|
It doesn't make sense to introduce another configuration file format at this time since all it does is introduce ambiguity. |
Member
|
Please avoid implementation of a feature request until we can comment on that feature request. I agree with Mitch, there is dubious benefit to this change. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add aspire.config.yaml/.yml as alternatives to aspire.config.json. YAML is parsed via YamlDotNet's AOT-safe event-based API, converted to JSON, then deserialized through the existing source-gen pipeline. Save preserves the source format. Errors if multiple formats exist.
Things covered:
ConfigurationService+ConfigurationHelperYAML supportxlftranslations auto-generatedThings to consider:
xlffiles havestate="new"for the new stringsExists()check is used in several places: updated it to check all formatsNot in scope (potential follow-ups):
aspire new scaffoldingstill creates JSON by default (correct per issue: "JSON/JSONC would remain the default")Fixes #15508
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: