Skip to content

Fix scroll event listener memory leak in homepage header #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IEvangelist merged 3 commits into from
Jan 13, 2026
Merged

Fix scroll event listener memory leak in homepage header #242

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35ce067
Initial plan
Copilot Jan 13, 2026
e330b5d
Fix scroll event listener memory leak using AbortController
Copilot Jan 13, 2026
7fac8c9
Add non-null assertion for scrollController.signal access
Copilot Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/frontend/src/components/starlight/Header.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,16 @@ import { isHomepage } from "@utils/helpers";
}

<script>
// Store the AbortController to manage scroll listener lifecycle
let scrollController: AbortController | null = null;

function initHomepageHeader() {
// Abort any existing scroll listener before setting up a new one
if (scrollController) {
scrollController.abort();
}
scrollController = new AbortController();

const searchWrapper = document.querySelector('[data-homepage-search]');
const titleWrapper = document.querySelector('[data-homepage-title]');
const siteTitleText = titleWrapper?.querySelector('.site-title .sr-only');
Expand Down Expand Up @@ -76,7 +85,11 @@ import { isHomepage } from "@utils/helpers";
checkScroll();

// Check on scroll (throttled with requestAnimationFrame)
window.addEventListener('scroll', onScroll, { passive: true });
// Use AbortController signal to automatically remove listener when aborted
window.addEventListener('scroll', onScroll, {
passive: true,
signal: scrollController!.signal,
});
}

// Run on initial load
Expand Down