Repository navigation
.NET: Remove legacy Azure Persistent integration tests - #9588
Roger Barreto (rogerbarreto) merged 1 commit into
Conversation
Retire Azure Persistent v1 live integration coverage while preserving the product package, offline unit tests, and DeepResearch sample. Refs microsoft#9587
There was a problem hiding this comment.
🔵 Needs a closer look
Permanently retiring live coverage for a retained production package needs maintainer agreement, which the supplied PR and issue context do not establish.
No open issues 🎉
What changed in this PR
Retires the legacy Azure Persistent/v1 live integration suite to address the merge-queue disruption described in #9587. This removes test coverage, not the underlying service or SDK failures.
Changes:
- Deletes the integration project, six test classes, and its fixture.
- Removes the project’s solution registration.
- Leaves production APIs, offline unit tests, DeepResearch, shared helpers, and CI policies unchanged.
| File | Description |
|---|---|
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentStructuredOutputRunTests.cs |
Removes structured-output live tests. |
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentRunTests.cs |
Removes agent-run live tests. |
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentRunStreamingTests.cs |
Removes streaming agent-run live tests. |
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentFixture.cs |
Removes the suite-specific Azure fixture. |
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentCreateTests.cs |
Removes agent-creation live tests. |
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistent.IntegrationTests.csproj |
Deletes the retired test project. |
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsChatClientAgentRunTests.cs |
Removes chat-client agent live tests. |
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsChatClientAgentRunStreamingTests.cs |
Removes streaming chat-client agent live tests. |
dotnet/agent-framework-dotnet.slnx |
Removes the deleted project’s registration. |
Review effort: Balanced
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): ac59813c5518
Model: gpt-5.6-sol
Overview
The PR consistently retires the flaky legacy Persistent/v1 live integration suite while preserving the production provider, offline unit tests, DeepResearch sample, shared conformance coverage, and CI infrastructure. Filesystem-based integration-test discovery ensures the deleted project is no longer selected, and repository references show no dangling registration. No publishable Critical, High, or Medium defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Motivation & Context
The legacy Azure Persistent/v1 live integration suite repeatedly stalls or fails with streaming/network errors on both integration-test platforms, blocking the merge queue as documented in #9587. The requested resolution is now to retire that integration-test coverage, replacing the earlier temporary-skip and separate root-cause-fix proposal.
This removes the obsolete live test suite; it does not claim to fix the upstream service or SDK, remove production APIs, or retire the DeepResearch sample.
Description & Review Guide
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests(the project, six test classes, and its fixture), and remove the project's entry fromdotnet/agent-framework-dotnet.slnx. No Skip annotations are added.Microsoft.Agents.AI.AzureAI.Persistent, its offline unit tests, DeepResearch, shared conformance/configuration/credential helpers, every other integration project, and all CI workflows/gates. Neither solution filter references the removed suite, and the tracked-reference audit found no other registrations requiring edits.Local verification used Windows and .NET SDK 10.0.402, with Debug configuration throughout. Commands below ran from
dotnet/except the Git check. Missing project assets were restored through the normal scoped build commands.dotnet build tests\Microsoft.Agents.AI.AzureAI.Persistent.UnitTests\Microsoft.Agents.AI.AzureAI.Persistent.UnitTests.csproj -c Debug --tl:off --warnaserrordotnet build tests\Foundry.IntegrationTests\Foundry.IntegrationTests.csproj -c Debug --tl:off --warnaserrordotnet build samples\02-agents\Agents\Agent_Step15_DeepResearch\Agent_Step15_DeepResearch.csproj -c Debug --tl:off --warnaserrordotnet test --project tests\Microsoft.Agents.AI.AzureAI.Persistent.UnitTests\Microsoft.Agents.AI.AzureAI.Persistent.UnitTests.csproj -f net10.0 -c Debug --no-build --report-xunit-xml --report-xunit-xml-filename retirement-units-net10.0.xml --results-directory $artifacts$artifactswas a local session-artifact directory outside the repository.dotnet test --project tests\Microsoft.Agents.AI.AzureAI.Persistent.UnitTests\Microsoft.Agents.AI.AzureAI.Persistent.UnitTests.csproj -f net472 -c Debug --no-build --report-xunit-xml --report-xunit-xml-filename retirement-units-net472.xml --results-directory $artifactsdotnet test --project tests\Foundry.IntegrationTests\Foundry.IntegrationTests.csproj -f net10.0 -c Debug --no-build --list-testsdotnet test --project tests\Foundry.IntegrationTests\Foundry.IntegrationTests.csproj -f net472 -c Debug --no-build --list-testsdotnet sln agent-framework-dotnet.slnx listgit diff --check origin/main HEADNo live Persistent/v1 API calls or full-solution unit/integration runs were performed. The removed suite is not being reported as passing or as temporarily skipped.
Related Issue
Fixes #9587
The issue now requests this single retirement PR, superseding the original two-PR plan. No competing open PR was found for #9587. This is separate from the OAuth consent work in #9565 and does not contain its changes. The reporter explicitly requested the removal; a
ready-for-implementationlabel or separate public maintainer agreement has not been established, so the corresponding contribution checklist item remains unchecked.AI Assistance
AI assistance details: Copilot assisted with dependency/reference inspection, the scoped test-suite removal, local verification, and this PR description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.