[SergeyMenshykh]

Motivation & Context

Make the MCP skills cache easier to understand by naming its stored skill list and page lifetimes a snapshot, and configuring discovery once when the cache is created. This is a naming and structural refactor; discovery and caching logic are unchanged.

Description

• Rename McpListedSkillsDiscoveryResult to McpListedSkillsSnapshot and use snapshot naming throughout the cache.
• Move discoverSkills from GetOrCreateAsync to the McpListedSkillsCache constructor.
• Update the loader, tests, and XML comments to match.
• Preserve existing discovery and caching behavior.

Related Issue

N/A

Contribution Checklist

• The code builds clean without any errors or warnings
• All unit tests pass, and I have added new tests where possible
• The PR follows the Contribution Guidelines
• This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
• This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.

[Copilot]

🟢 Approval recommended

Static review supports this behavior-preserving refactor with no blocking issues identified; tests were not run.

No open issues 🎉

What changed in this PR

Clarifies the .NET MCP skills cache structure while preserving discovery and caching behavior.

Changes:

• Renames discovery results to snapshots.
• Moves the discovery callback into the cache constructor.
• Updates tests and adds null-callback validation coverage.

File	Description
dotnet/​tests/​Microsoft.Agents.AI.Mcp.UnitTests/​Skills/​Listed/​McpListedSkillsCacheTests.cs	Updates cache usage and tests constructor validation.
dotnet/​src/​Microsoft.Agents.AI.Mcp/​Skills/​Listed/​McpListedSkillsSnapshot.cs	Introduces the renamed snapshot container.
dotnet/​src/​Microsoft.Agents.AI.Mcp/​Skills/​Listed/​McpListedSkillsLoader.cs	Supplies discovery during cache construction.
dotnet/​src/​Microsoft.Agents.AI.Mcp/​Skills/​Listed/​McpListedSkillsDiscoveryResult.cs	Removes the former container name.
dotnet/​src/​Microsoft.Agents.AI.Mcp/​Skills/​Listed/​McpListedSkillsCache.cs	Stores the callback and adopts snapshot terminology.

_{Review effort: Balanced}

[github-actions]

MAF Automated Review — Iteration 1

Result: No findings
Scope: full PR (1 commit(s)): c557f78ab2b9
Model: gpt-5.6-sol

Overview

This refactor consistently renames the cached discovery result as a snapshot and binds discovery once when each per-loader cache is constructed. Existing guardrails preserve serialized refresh, atomic snapshot publication, TTL semantics, cancellation behavior, and source-to-cache disposal ownership, with focused cache tests and broader end-to-end TTL tests covering those contracts. No publishable Critical, High, or Medium defect was established.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

[github-code-quality]

Code coverage overview

Languages: C#

C# / code-coverage/dotnet

feature-mcp-skills-n... 08851e6	sergeymenshykh-mcp-s... c557f78	+/-
86%	85%	-1%

View coverage of the 10 most impacted files.

File	feature-mcp-skills-n... 08851e6	sergeymenshykh-mcp-s... c557f78	+/-
/home/runner/wo...toryProvider.cs	95%	31%	-64%
/home/runner/wo...SessionStore.cs	100%	53%	-47%
/home/runner/wo...hellExecutor.cs	90%	73%	-17%
/home/runner/wo...SkillsSource.cs	89%	83%	-6%
/home/runner/wo...ctionVisitor.cs	81%	75%	-6%
/home/runner/wo...CopilotAgent.cs	72%	76%	+4%
/home/runner/wo...pListedSkill.cs	0%	93%	+93%
/home/runner/wo...SkillsLoader.cs	0%	100%	+100%
/home/runner/wo...dSkillsCache.cs	0%	100%	+100%
/home/runner/wo...ueExtensions.cs	0%	100%	+100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.