.NET: Suppress false positive Zip Slip alert - #7858
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8c7b4b0-21bf-4b63-ba64-75e5c4b7ab34
There was a problem hiding this comment.
Pull request overview
Adds a justified inline CodeQL suppression for a false-positive Zip Slip finding. Runtime behavior is unchanged.
Changes:
- Suppresses SM02729 where archive destinations are validated by
ResolveDestination.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): ebb03924eda7
Model: gpt-5.6-sol
Overview
This PR adds only an inline CodeQL suppression and does not alter runtime behavior. The justification is supported by canonical path resolution, separator-aware containment checks, rejection before filesystem writes, and tests covering traversal and case-sensitive sibling escapes. No publishable issue was introduced by the change.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8c7b4b0-21bf-4b63-ba64-75e5c4b7ab34
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8c7b4b0-21bf-4b63-ba64-75e5c4b7ab34
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8c7b4b0-21bf-4b63-ba64-75e5c4b7ab34
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8c7b4b0-21bf-4b63-ba64-75e5c4b7ab34
d945631 to
d460522
Compare
Motivation & Context
Suppresses the false-positive CodeQL Zip Slip finding SM02729.
Description & Review Guide
Related Issue
N/A - internal CodeQL finding SM02729.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) - a workflow keeps the label and title prefix in sync automatically.