Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 35 additions & 12 deletions python/packages/core/agent_framework/_agent_hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -857,21 +857,44 @@ def _agent_updates_from_response(response: AgentResponse[Any]) -> list[AgentResp


def _tool_names(context: AgentContext) -> list[str]:
"""Project the registered tool names for ``agent_startup`` (spec ``tools_registered``)."""
from ._tools import _get_tool_name, normalize_tools # type: ignore[reportPrivateUsage]
"""Project the registered tool names for ``agent_startup`` (spec ``tools_registered``).

The projection mirrors run preparation: constructor tools, agent/run options tools,
and the run-level tool overrides are all combined, so a run that supplies extra
tools still reports the agent's configured tools alongside them.
"""
from ._tools import _get_tool_name, normalize_tools # pyright: ignore[reportPrivateUsage]

merged: list[Any] = []

def _extend(source: Any) -> None:
if source is None:
return
try:
merged.extend(normalize_tools(source))
except Exception:
logger.warning(
"agent-hooks could not normalize the run's tools for the agent_startup projection."
)

agent = context.agent

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense for the source selection behind tools_registered to reuse the same helper as _prepare_run_context. This block independently combines agent.tools, default_options["tools"], options["tools"], and context.tools, while run preparation has separate precedence and uniqueness rules. A call supplying both tools= and options["tools"] reports all sources at startup even though the prepared model options follow a different path. Extracting one _resolve_run_tools(...) helper for both places would keep the audit snapshot aligned.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, in general this handling of tools should be done once across the stack, not once here in this hook and again later on!

_extend(getattr(agent, "tools", None))
default_options = getattr(agent, "default_options", None)
if isinstance(default_options, Mapping):
_extend(cast(Mapping[str, Any], default_options).get("tools"))
options = context.options
if isinstance(options, Mapping):
_extend(cast(Mapping[str, Any], options).get("tools"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we avoid consuming options["tools"] while building tools_registered? normalize_tools flattens supported iterable tool collections with list(...), and _middleware_handler later forwards this same object into run preparation. A generator or other one-shot collection is reported at startup and then exhausted, so the model receives no run tools. Would normalizing once and replacing the forwarded option with the reusable list keep this projection observational?

_extend(context.tools)

tools: Any = context.tools if context.tools is not None else getattr(context.agent, "tools", None)
if tools is None:
return []
try:
normalized = normalize_tools(tools)
except Exception:
logger.warning("agent-hooks could not normalize the run's tools for the agent_startup projection.")
return []
names: list[str] = []
for item in normalized:
seen: set[str] = set()
for item in merged:
name = _get_tool_name(item)
names.append(name if name else type(item).__name__)
label = name if name else type(item).__name__
if label not in seen:
seen.add(label)
names.append(label)
return names


Expand Down
40 changes: 40 additions & 0 deletions python/packages/core/tests/core/test_agent_hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,12 @@ def weather_tool(location: str) -> str:
return f"weather in {location}"


@tool(approval_mode="never_require")
def search_tool(query: str) -> str:
"""Run a search."""
return f"results for {query}"


weather_tool_calls: list[str] = []


Expand Down Expand Up @@ -293,6 +299,40 @@ async def test_full_tool_run_emits_complete_ordered_session(chat_client_base: Mo
assert pre_tool["tool_call"]["id"] == "call_1"


@requires_sdk
async def test_agent_startup_projects_constructor_registered_tools(chat_client_base: MockBaseChatClient) -> None:
guard = AllowGuard()
agent = Agent(
client=chat_client_base,
tools=[weather_tool],
middleware=[create_agent_hooks_middleware([guard])],
)

await agent.run("hello")

startup = guard.contexts_for("agent_startup")
assert len(startup) == 1
assert startup[0]["agent_init"]["tools_registered"] == ["weather_tool"]


@requires_sdk
async def test_agent_startup_merges_run_tools_with_constructor_tools(
chat_client_base: MockBaseChatClient,
) -> None:
guard = AllowGuard()
agent = Agent(
client=chat_client_base,
tools=[weather_tool],
middleware=[create_agent_hooks_middleware([guard])],
)

await agent.run("hello", tools=[search_tool])

startup = guard.contexts_for("agent_startup")
assert len(startup) == 1
assert startup[0]["agent_init"]["tools_registered"] == ["weather_tool", "search_tool"]


@requires_sdk
async def test_input_projection_is_faithful(chat_client_base: MockBaseChatClient) -> None:
guard = AllowGuard()
Expand Down
Loading