Skip to content

[monobuild] Gate public symbol publish behind PublishPublicSymbols param #6644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kyaw Thant (kythant) wants to merge 1 commit into
base: release/dev/monobuild
Choose a base branch
from
Draft

[monobuild] Gate public symbol publish behind PublishPublicSymbols param #6644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions build/AzurePipelinesTemplates/WindowsAppSDK-BuildInstaller-Steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ parameters:
- name: IsOfficial
type: boolean
default: false
# Gates the public SymWeb/MSDL symbol publish inside WindowsAppSDK-PublishSymbol-Steps.yml.
# Default true preserves standalone per-component behavior; the monobuild passes false while
# the public symbol-publish service connection is being sorted.
- name: PublishPublicSymbols
type: boolean
default: true
- name: runStaticAnalysis
type: boolean
default: false
Expand Down Expand Up @@ -333,6 +339,7 @@ steps:
InnerParams:
SearchPattern: '$(foundationRepoPath)BuildOutput\$(buildConfiguration)\$(buildPlatform)\WindowsAppRuntimeInstall\*.pdb'
IsOfficial: ${{ parameters.IsOfficial }}
PublishPublicSymbols: ${{ parameters.PublishPublicSymbols }}
condition: and(succeeded(), ne(variables.SkipInstallerBuild, true))

- ${{ if eq(parameters.SignOutput, 'true') }}:
Expand Down
7 changes: 7 additions & 0 deletions build/AzurePipelinesTemplates/WindowsAppSDK-BuildVSIX-Steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ parameters:
- name: IsOfficial
type: boolean
default: false
# Gates the public SymWeb/MSDL symbol publish inside WindowsAppSDK-PublishSymbol-Steps.yml.
# Default true preserves standalone per-component behavior; the monobuild passes false while
# the public symbol-publish service connection is being sorted.
- name: PublishPublicSymbols
type: boolean
default: true
- name: runStaticAnalysis
type: boolean
default: true
Expand Down Expand Up @@ -244,6 +250,7 @@ steps:
InnerParams:
SearchPattern: '$(FoundationRepoPath)dev\Templates\VSIX\BuildOutput\obj\AnyCPU$(buildConfiguration)\**\WindowsAppSDK*.pdb'
IsOfficial: ${{ parameters.IsOfficial }}
PublishPublicSymbols: ${{ parameters.PublishPublicSymbols }}

- task: CopyFiles@2
displayName: 'Stage VSIX component JSONs'
Expand Down
7 changes: 7 additions & 0 deletions build/AzurePipelinesTemplates/WindowsAppSDK-PackTransportPackage-Steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ parameters:
- name: IsOfficial
type: boolean
default: false
# Gates the public SymWeb/MSDL symbol publish inside WindowsAppSDK-PublishSymbol-Steps.yml.
# Default true preserves standalone per-component behavior; the monobuild passes false while
# the public symbol-publish service connection is being sorted.
- name: PublishPublicSymbols
type: boolean
default: true
- name: PublishPackage
type: boolean
default: false
Expand Down Expand Up @@ -117,6 +123,7 @@ steps:
InnerParams:
SearchPattern: '$(Build.ArtifactStagingDirectory)\symbols\**\*.pdb'
IsOfficial: ${{ parameters.IsOfficial }}
PublishPublicSymbols: ${{ parameters.PublishPublicSymbols }}

# ── Determine version + pack NuGet ──
- template: WindowsAppSDK-DetermineVersion-Wrapper.yml
Expand Down