clear warnings in foundation pipeline

build/AzurePipelinesTemplates/WindowsAppSDK-BuildInstaller-Steps.yml

@@ -221,8 +221,6 @@ steps:
     platform: '$(buildPlatform)'
     configuration: '$(buildConfiguration)'
     msbuildArgs: /binaryLogger:$(ob_outputDirectory)\binlogs\WindowsAppRuntimeInstall.$(buildPlatform).$(buildConfiguration).binlog
-    ${{ if eq( parameters.runStaticAnalysis, 'true') }}:
-      createLogFile: true
 
 # The VSBuild@1 task above seems to be able to do inline PREfast scanning with the EO-compliant ruleset now. So, we don't seem to
 # need the following any more. Commenting it out for now and observe a bit more. Remove it when we feel comfortable.

build/AzurePipelinesTemplates/WindowsAppSDK-BuildVSIX-Steps.yml

@@ -105,8 +105,6 @@ steps:
     platform: 'Any CPU'
     configuration: '$(buildConfiguration)'
     msBuildArgs: '/p:OptionalVSIXVersion="${{ parameters.OptionalVSIXVersion }}" /p:WindowsAppSDKVersion="$(WindowsAppSDKPackageVersion)" /p:EnableExperimentalVSIXFeatures="${{ parameters.EnableExperimentalVSIXFeatures }}" /binaryLogger:$(ob_outputDirectory)\binlogs\StandaloneVSIX.build.binlog'
-    ${{ if eq( parameters.runStaticAnalysis, 'true') }}:
-      createLogFile: true
 
 - ${{ if eq(parameters.runStaticAnalysis, 'true') }}:
   - task: SDLNativeRules@3
@@ -141,8 +139,6 @@ steps:
     platform: 'Any CPU'
     configuration: '$(buildConfiguration)'
     msBuildArgs: '/restore /p:OptionalVSIXVersion="${{ parameters.OptionalVSIXVersion }}" /p:WindowsAppSDKVersion="$(WindowsAppSDKPackageVersion)" /p:EnableExperimentalVSIXFeatures="${{ parameters.EnableExperimentalVSIXFeatures }}" /p:Deployment="Component" /binaryLogger:$(ob_outputDirectory)\binlogs\ComponentVSIX.build.binlog'
-    ${{ if eq( parameters.runStaticAnalysis, 'true') }}:
-      createLogFile: true
 
 - ${{ if eq(parameters.runStaticAnalysis, 'true') }}:
   - task: SDLNativeRules@3

dev/VSIX/Shared/WizardImplementation.cs

@@ -27,8 +27,18 @@ public partial class NuGetPackageInstaller : IWizard
         public void RunStarted(object automationObject, Dictionary<string, string> replacementsDictionary, WizardRunKind runKind, object[] customParams)
         {
             ThreadHelper.ThrowIfNotOnUIThread();
-            _componentModel = (IComponentModel)ServiceProvider.GlobalProvider.GetService(typeof(SComponentModel));
+            _componentModel = ServiceProvider.GlobalProvider.GetService(typeof(SComponentModel)) as IComponentModel;
+            if (_componentModel == null)
+            {
+                System.Diagnostics.Debug.WriteLine("Warning: Could not obtain IComponentModel service.");
+            }
+
             _waitDialog = ServiceProvider.GlobalProvider.GetService(typeof(SVsThreadedWaitDialog)) as IVsThreadedWaitDialog2;
+            if (_waitDialog == null)
+            {
+                System.Diagnostics.Debug.WriteLine("Warning: Could not obtain IVsThreadedWaitDialog2 service.");
+            }
+
             if (_componentModel != null)
             {
                 _nugetProjectUpdateEvents = _componentModel.GetService<IVsNuGetProjectUpdateEvents>();
@@ -68,19 +78,27 @@ private async Task InstallNuGetPackagesAsync()
             await ThreadHelper.JoinableTaskFactory.RunAsync(async () =>
             {
                 await ThreadHelper.JoinableTaskFactory.SwitchToMainThreadAsync();
-                int canceled; // This variable will store the status after the dialog is closed
+                int canceled = 0; // Initialize as not canceled
 
                 // Start the package installation task but do not await it here
                 var installationTask = StartInstallationAsync();
 
                 // Start the threaded wait dialog
-                _waitDialog.StartWaitDialog(null, "Installing NuGet packages into project...", null, null, "Operation in progress...", 0, false, true);
+                if (_waitDialog != null)
+                {
+                    _waitDialog.StartWaitDialog(null, "Installing NuGet packages into project...", null, null, "Operation in progress...", 0, false, true);
+                }
 
                 // Now await the installation task to complete
                 await installationTask;
 
                 // Once the installation is complete, end the wait dialog
-                _waitDialog.EndWaitDialog(out canceled);
+                if (_waitDialog != null)
+                {
+                    _waitDialog.EndWaitDialog(out canceled);
+                }
+                // If _waitDialog is null, canceled remains 0 (not canceled)
+
                 // Check if the process was canceled before proceeding
                 if (canceled == 0) // If not canceled, finalize the process
                 {
@@ -92,6 +110,13 @@ await ThreadHelper.JoinableTaskFactory.RunAsync(async () =>
 
         private async Task StartInstallationAsync()
         {
+            if (_componentModel == null)
+            {
+                await ThreadHelper.JoinableTaskFactory.SwitchToMainThreadAsync();
+                LogError("ComponentModel service is not available.");
+                return;
+            }
+
             IVsPackageInstaller installer = _componentModel.GetService<IVsPackageInstaller>();
             if (installer == null)
             {

installer/dev/main.cpp

@@ -15,7 +15,7 @@ using namespace winrt;
 
 using namespace WindowsAppRuntimeInstaller::Console;
 
-int wmain(int argc, wchar_t *argv[])
+int __cdecl wmain(int argc, wchar_t *argv[])
 {
     init_apartment();
 

test/StaticValidationTests/Program.cs

@@ -49,10 +49,10 @@ public string SignTool
 
     class CertValidation
     {
-        public string File;                 
-        public string IssuedToName;
-        public string ExtraSignToolFlags;   // Extra flags to pass to signtool.exe.
-        public int ValidationCount = 0;     // This counter is to ensure we found the files we were looking for.
+        public string File { get; set; }                 
+        public string IssuedToName { get; set; }
+        public string ExtraSignToolFlags { get; set; }   // Extra flags to pass to signtool.exe.
+        public int ValidationCount { get; set; } = 0;     // This counter is to ensure we found the files we were looking for.
     }
 
     class Program