Symbol for property assignments in Salsa/ES6 constructors #8844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously no symbol at all was created, meaning that Salsa didn't track properties in ES6 code.
|
@RyanCavanaugh can you take a look? |
|
👍 |
|
i wonder if we should just do this all the time for both ts and js and then show an error for property assignments with no declarations in TS. |
|
👍 |
|
I added a separate bug for making this work in TypeScript: #8846 |
sandersn
deleted the
create-symbol-for-assignments-in-javascript-constructors
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8777
Previously no symbol at all was created, meaning that Salsa didn't track properties in ES6 code.