Navigation bar items in methods #7178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinganho
changed the title
tinganho
changed the title
src/services/navigationBar.ts
Outdated
| switch (node.kind) { | ||
| case SyntaxKind.ClassDeclaration: | ||
| topLevelNodes.push(node); | ||
| forEach((<ClassDeclaration>node).members, (node) => { |
Member
There was a problem hiding this comment.
Use for-of over forEach unless you're unsure whether the first argument is undefined
Contributor
Author
|
@DanielRosenwasser I addressed your feedback. |
Contributor
|
Ping @DanielRosenwasser. can you take another look. |
| if (forEach(nodes, s => s.kind === SyntaxKind.FunctionDeclaration && !isEmpty((<FunctionDeclaration>s).name.text))) { | ||
| return true; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Explicitly return false
Member
|
Looks fine to me. Can you pull in from master to resolve any conflicts @tinganho? |
tinganho
force-pushed
the
navigationBarItemTopLevel
branch
from
50a9481 to
b7c3547
Compare
Contributor
Author
|
Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative PR to #7177. Fixes #6828.