Run extension tagging on main - #64209
Open
Jake Bailey (jakebailey) wants to merge 2 commits into
Open
Conversation
Jake Bailey (jakebailey)
requested review from
Daniel Rosenwasser (DanielRosenwasser)
and
a balanced review from Copilot
September 9, 2026 00:12
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Jake Bailey (jakebailey)
enabled auto-merge
September 9, 2026 00:13
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 9, 2026 00:13
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The validation still permits adding a privileged pull_request trigger.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Moves VS Code extension tagging to trusted pushes on main.
Changes:
- Replaces
pull_request_targetwith a filteredpushtrigger. - Updates checkout, concurrency, and workflow validation.
File summaries
| File | Description |
|---|---|
Herebyfile.mjs |
Validates the tagging workflow trigger. |
.github/workflows/tag-vscode-typescript.yml |
Tags extension releases after version bumps reach main. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| } | ||
| const tagWorkflow = fs.readFileSync("./.github/workflows/tag-vscode-typescript.yml", "utf8"); | ||
| if (!tagWorkflow.includes(" push:\n branches: [main]") || tagWorkflow.includes("pull_request_target") || tagWorkflow.includes("allow-unsafe-pr-checkout")) { |
Member
Author
There was a problem hiding this comment.
To be honest this would never happen and the workflow doesn't really need to check this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was wrong in #64139, due to GitHub security changes.