Restack skill - #64201
Open
Ryan Cavanaugh (RyanCavanaugh) wants to merge 4 commits into
Open
Conversation
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Copilot started reviewing on behalf of
Ryan Cavanaugh (RyanCavanaugh)
September 8, 2026 18:35
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Baseline verification is insufficient and the workflow omits the required baseline-accept step.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
.github/skills/restack/SKILL.md — This check does not establish that the new test reproduces the reported bug: every newly added… |
|
.github/skills/restack/SKILL.md — This step omits the command that copies generated files from baselines/local into the tracked… |
What changed in this PR
Adds a restacking skill for organizing TypeScript PR commits into test, fix, and baseline stages.
Changes:
- Defines the expected restacked commit sequence.
- Adds test and baseline verification guidance.
| File | Description |
|---|---|
.github/skills/restack/SKILL.md |
Adds the PR restacking workflow. |
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Copilot started reviewing on behalf of
Ryan Cavanaugh (RyanCavanaugh)
September 8, 2026 18:50
View session
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Sep 8, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The test-failure guidance can accept unrelated failures and incorrectly describes baseline mismatches.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
|
.github/skills/restack/SKILL.md — Checking only whether any test in the full run failed allows an unrelated or flaky failure to… |
Issues resolved since last review (2)
| Severity | Finding |
|---|---|
|
.github/skills/restack/SKILL.md — This step omits the command that copies generated files from baselines/local into the tracked… View resolved comment |
|
.github/skills/restack/SKILL.md — This check does not establish that the new test reproduces the reported bug: every newly added… View resolved comment |
Suppressed comments (1)
.github/skills/restack/SKILL.md:17
- This is inaccurate: the baseline harness calls
t.Errorffor new or changed baselines (tsc/internal/testutil/baseline/baseline.go:75-79), so a mismatch is a normal test failure even when its diff is expected. Stating otherwise can make agents misinterpret the required failing-test check.
Remember that baseline tests do not "fail" in the traditional sense; they are used to verify that the output matches the expected baseline.
Comment on lines
+15
to
+16
| Ensure that at least one test in the full run fails - you might be operating on a bad PR that didn't actually introduce a failing scenario! | ||
| If zero tests failed, abort and post a message explaining what you observed. |
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a skill to get agents to format their PRs in a more-reviewable commit history