Assume rootDir is the current configuration directory #62418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
There was a problem hiding this comment.
Pull Request Overview
This PR changes the TypeScript compiler's behavior to assume the configuration file directory as the root directory when rootDir is not explicitly specified. Instead of requiring composite: true to enable this behavior, the change makes it apply whenever a configuration file (configFilePath) is present.
- Removes the requirement for
composite: trueto use the configuration directory as the root - Updates the common source directory resolution logic to use
configFilePathexistence instead ofcomposite && configFilePath - Affects output path generation, module resolution, and emit behavior
Reviewed Changes
Copilot reviewed 57 out of 59 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/compiler/utilities.ts | Updates condition to use configFilePath instead of composite && configFilePath for root directory determination |
| src/compiler/moduleNameResolver.ts | Changes module resolution to assume config directory as root when configFilePath exists |
| src/compiler/emitter.ts | Updates emit logic to use config directory as common source directory when configFilePath is present |
| src/testRunner/unittests/tsbuild/outputPaths.ts | Updates test expectations and adds test name differentiation |
| src/testRunner/unittests/helpers/monorepoSymlinkedSiblingPackages.ts | Adds explicit rootDir to test configurations to maintain expected behavior |
| tests/baselines/reference/* | Multiple baseline file updates reflecting the new output path behavior |
Files not reviewed (1)
- tests/baselines/reference/commonSourceDirectory_dts.js.map: Language not supported
|
@typescript-bot test it |
|
Hey @jakebailey, the results of running the DT tests are ready. Everything looks the same! |
|
@jakebailey Here are the results of running the user tests with tsc comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Ouch, looking bad for pyright and mui-docs. |
|
@jakebailey Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
This seems correct but the fallout in resolution in these projects seems like a non sequitur. This is because |
|
For pyright, both baseUrl and rootDir are unset (hence them changing): https://github.com/microsoft/pyright/blob/main/packages/pyright/tsconfig.json Perhaps this just means they could explicitly define rootDir to be a parent dir? IIRC the layout should really have used project references, but instead has every project emit each other's files into their own dist (for better or for worse.... mainly the latter). |
|
I think its "tryLoadInputFileForPath" where it tries to guess the input path where there is change in behavior of what we do if "rootDir" is known vs computed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62194