Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on SEF expression statements #60936

Closed
wants to merge 2 commits into from

Conversation

RyanCavanaugh
Copy link
Member

ref https://bsky.app/profile/adamchalmers.com/post/3lfb3mu4pjs2d

Just here for top400, this breaks sooooooooo many baselines

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 8, 2025
@RyanCavanaugh
Copy link
Member Author

@typescript-bot test top800

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 8, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top800 ✅ Started

@RyanCavanaugh
Copy link
Member Author

Prior run failed due to a network hiccup

@typescript-bot test top800

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top800 ✅ Started

@RyanCavanaugh
Copy link
Member Author

Different problems now?

@typescript-bot test top800

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top800 ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the top 800 repos with tsc comparing main and refs/pull/60936/merge:

Something interesting changed - please have a look.

Details

aidenybai/react-scan

3 of 5 projects failed to build with the old tsc and were ignored

packages/website/tsconfig.json

alan2207/bulletproof-react

apps/nextjs-app/tsconfig.json

angular-ui/ui-router

1 of 5 projects failed to build with the old tsc and were ignored

test/tsconfig.json

anthropics/anthropic-quickstarts

financial-data-analyst/tsconfig.json

customer-support-agent/tsconfig.json

apollographql/apollo-client

1 of 13 projects failed to build with the old tsc and were ignored

tsconfig.json

src/tsconfig.json

integration-tests/next/tsconfig.json

arc53/DocsGPT

extensions/react-widget/tsconfig.json

frontend/tsconfig.json

ariakit/ariakit

1 of 6 projects failed to build with the old tsc and were ignored

website/tsconfig.json

better-auth/better-auth

14 of 15 projects failed to build with the old tsc and were ignored

examples/browser-extension-example/tsconfig.json

blakeblackshear/frigate

web/tsconfig.json

Blazity/next-enterprise

tsconfig.json

bvaughn/react-error-boundary

tsconfig.json

  • error TS2695: Left side of comma operator is unused and has no side effects.

colinhacks/zod

1 of 5 projects failed to build with the old tsc and were ignored

tsconfig.json

configs/tsconfig.types.json

  • error TS2695: Left side of comma operator is unused and has no side effects.

configs/tsconfig.esm.json

  • error TS2695: Left side of comma operator is unused and has no side effects.

continuedev/continue

5 of 12 projects failed to build with the old tsc and were ignored

extensions/vscode/tsconfig.json

core/tsconfig.npm.json

core/tsconfig.json

binary/tsconfig.json

gui/tsconfig.json

CopilotKit/CopilotKit

13 of 28 projects failed to build with the old tsc and were ignored

examples/coagents-wait-user-input/ui/tsconfig.json

examples/coagents-travel/ui/tsconfig.json

examples/coagents-starter/ui/tsconfig.json

examples/coagents-shared-state/ui/tsconfig.json

examples/coagents-routing/ui/tsconfig.json

examples/coagents-research-canvas/ui/tsconfig.json

examples/coagents-qa-text/ui/tsconfig.json

examples/coagents-qa-native/ui/tsconfig.json

examples/coagents-qa/ui/tsconfig.json

examples/coagents-ai-researcher/ui/tsconfig.json

documenso/documenso

13 of 17 projects failed to build with the old tsc and were ignored

apps/documentation/tsconfig.json

Dokploy/dokploy

2 of 6 projects failed to build with the old tsc and were ignored

apps/dokploy/tsconfig.server.json

apps/dokploy/tsconfig.json

eclipse-che/che

tests/e2e/tsconfig.json

elysiajs/elysia

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.test.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the top 800 repos suite

Details

ether/etherpad-lite

src/tsconfig.json

bin/tsconfig.json

ethers-io/ethers.js

2 of 6 projects failed to build with the old tsc and were ignored

tsconfig.types.json

facebook/docusaurus

25 of 42 projects failed to build with the old tsc and were ignored

packages/docusaurus-babel/tsconfig.json

packages/create-docusaurus/tsconfig.json

FuelLabs/fuels-ts

34 of 56 projects failed to build with the old tsc and were ignored

apps/demo-wallet-sdk-react/tsconfig.json

gcanti/fp-ts

2 of 5 projects failed to build with the old tsc and were ignored

tsconfig.json

dtslint/tsconfig.json

getsentry/sentry-javascript

155 of 203 projects failed to build with the old tsc and were ignored

dev-packages/e2e-tests/test-applications/nextjs-turbo/tsconfig.json

dev-packages/e2e-tests/test-applications/nextjs-15/tsconfig.json

dev-packages/e2e-tests/test-applications/nextjs-14/tsconfig.json

dev-packages/e2e-tests/test-applications/nextjs-13/tsconfig.json

gorhom/react-native-bottom-sheet

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

graphile/crystal

6 of 11 projects failed to build with the old tsc and were ignored

grafast/grafast/tsconfig.test.json

hoarder-app/hoarder

3 of 17 projects failed to build with the old tsc and were ignored

packages/shared-react/tsconfig.json

apps/web/tsconfig.json

immutable-js/immutable-js

1 of 4 projects failed to build with the old tsc and were ignored

website/tsconfig.json

inkonchain/ink-kit

tsconfig.json

ionic-team/ionic-framework

23 of 24 projects failed to build with the old tsc and were ignored

core/tsconfig.json

ItzCrazyKns/Perplexica

tsconfig.json

ui/tsconfig.json

ixartz/Next-js-Boilerplate

tsconfig.json

janhq/jan

19 of 22 projects failed to build with the old tsc and were ignored

docs/tsconfig.json

javascript-obfuscator/javascript-obfuscator

tsconfig.json

test/tsconfig.test.json

src/tsconfig.typings.json

  • error TS2695: Left side of comma operator is unused and has no side effects.

johannesjo/super-productivity

1 of 4 projects failed to build with the old tsc and were ignored

electron/tsconfig.electron.json

labring/FastGPT

3 of 9 projects failed to build with the old tsc and were ignored

packages/global/tsconfig.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the top 800 repos suite

Details

labring/sealos

19 of 23 projects failed to build with the old tsc and were ignored

frontend/packages/ui/tsconfig.json

frontend/packages/client-sdk/tsconfig.json

leerob/next-saas-starter

tsconfig.json

leptonai/search\_with\_lepton

web/tsconfig.json

microsoft/azuredatastudio

15 of 67 projects failed to build with the old tsc and were ignored

samples/sp_whoIsActive/tsconfig.json

samples/extensionSamples/tsconfig.json

extensions/sql-migration/tsconfig.json

extensions/server-report/tsconfig.json

extensions/kusto/tsconfig.json

extensions/git/tsconfig.json

extensions/azuremonitor/tsconfig.json

microsoft/playwright

4 of 13 projects failed to build with the old tsc and were ignored

utils/generate_types/test/tsconfig.json

microsoft/SandDance

17 of 25 projects failed to build with the old tsc and were ignored

packages/powerbi/tsconfig.json

extensions/azdata-sanddance/tsconfig.json

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

extensions/git/tsconfig.json

build/tsconfig.build.json

Milkdown/milkdown

2 of 33 projects failed to build with the old tsc and were ignored

packages/integrations/vue/tsconfig.json

miurla/morphic

tsconfig.json

molefrog/wouter

packages/wouter/tsconfig.json

motion-canvas/motion-canvas

13 of 18 projects failed to build with the old tsc and were ignored

packages/core/tsconfig.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the top 800 repos suite

Details

mui/material-ui

23 of 85 projects failed to build with the old tsc and were ignored

test/tsconfig.json

packages/mui-utils/tsconfig.json

packages/mui-system/tsconfig.json

packages/mui-system/test/typescript/moduleAugmentation/gridCustomBreakpoints.tsconfig.json

packages/mui-styles/tsconfig.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the top 800 repos suite

Details

neoclide/coc.nvim

tsconfig.json

nextauthjs/next-auth

24 of 45 projects failed to build with the old tsc and were ignored

docs/tsconfig.json

nextui-org/nextui

2 of 85 projects failed to build with the old tsc and were ignored

packages/core/react/tsconfig.json

NG-ZORRO/ng-zorro-antd

4 of 11 projects failed to build with the old tsc and were ignored

components/tsconfig.spec.json

components/tsconfig.lib.prod.json

components/tsconfig.json

niklasvh/html2canvas

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

nodejs/nodejs.org

apps/site/tsconfig.json

noodle-run/noodle

tsconfig.json

Nutlope/roomGPT

tsconfig.json

openstatusHQ/openstatus

7 of 23 projects failed to build with the old tsc and were ignored

packages/ui/tsconfig.json

outline/outline

tsconfig.json

pmndrs/zustand

tsconfig.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the top 800 repos suite

Details

Portkey-AI/gateway

1 of 2 projects failed to build with the old tsc and were ignored

cookbook/integrations/vercel/tsconfig.json

probot/probot

test/tsconfig.json

QwikDev/partytown

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

radix-ui/primitives

tsconfig.json

ssr-testing/tsconfig.json

radix-ui/themes

1 of 2 projects failed to build with the old tsc and were ignored

packages/radix-ui-themes/tsconfig.json

react-cosmos/react-cosmos

10 of 15 projects failed to build with the old tsc and were ignored

packages/react-cosmos-core/tsconfig.build.json

react-hook-form/react-hook-form

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the top 800 repos suite

Details

react-navigation/react-navigation

9 of 14 projects failed to build with the old tsc and were ignored

tsconfig.json

packages/react-native-drawer-layout/tsconfig.build.json

example/tsconfig.json

Redocly/redoc

tsconfig.lib.json

tsconfig.json

reduxjs/react-redux

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

redwoodjs/redwood

66 of 105 projects failed to build with the old tsc and were ignored

packages/router/tsconfig.cjs.json

ritwickdey/vscode-live-server

tsconfig.json

runtipi/runtipi

packages/frontend/tsconfig.json

shadcn-ui/ui

20 of 26 projects failed to build with the old tsc and were ignored

templates/monorepo-next/apps/web/tsconfig.json

socketio/socket.io

12 of 32 projects failed to build with the old tsc and were ignored

packages/socket.io-adapter/tsconfig.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the top 800 repos suite

Details

software-mansion/react-native-gesture-handler

2 of 7 projects failed to build with the old tsc and were ignored

tsconfig.json

tsconfig.build.json

example/tsconfig.json

e2e/web-tests/tsconfig.json

FabricExample/tsconfig.json

supabase/supabase

36 of 38 projects failed to build with the old tsc and were ignored

packages/ui/tsconfig.json

packages/common/tsconfig.json

t3-oss/create-t3-app

upgrade/tsconfig.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the top 800 repos suite

Details

teableio/teable

22 of 25 projects failed to build with the old tsc and were ignored

packages/ui-lib/tsconfig.json

theatre-js/theatre

16 of 24 projects failed to build with the old tsc and were ignored

packages/dataverse-experiments/tsconfig.json

packages/dataverse/devEnv/api-extractor.tsconfig.json

tinacms/tinacms

12 of 24 projects failed to build with the old tsc and were ignored

packages/next-tinacms-cloudinary/tsconfig.json

packages/@tinacms/mdx/tsconfig.json

tldraw/tldraw

14 of 21 projects failed to build with the old tsc and were ignored

templates/nextjs/tsconfig.json

apps/docs/tsconfig.content.json

tremorlabs/tremor-npm

tsconfig.json

triggerdotdev/trigger.dev

19 of 30 projects failed to build with the old tsc and were ignored

packages/react-hooks/tsconfig.json

tusen-ai/naive-ui

3 of 6 projects failed to build with the old tsc and were ignored

src/tsconfig.demo.json

twentyhq/twenty

3 of 11 projects failed to build with the old tsc and were ignored

packages/twenty-website/tsconfig.json

typehero/typehero

70 of 78 projects failed to build with the old tsc and were ignored

apps/og-image/tsconfig.json

TypeStrong/typedoc

1 of 5 projects failed to build with the old tsc and were ignored

src/test/converter2/tsconfig.json

umijs/umi

45 of 68 projects failed to build with the old tsc and were ignored

packages/lint/tsconfig.json

packages/bundler-esbuild/tsconfig.json

examples/vue-demo/tsconfig.json

upscayl/upscayl

tsconfig.json

renderer/tsconfig.json

vercel/ai-chatbot

tsconfig.json

vercel/commerce

tsconfig.json

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are some more interesting changes from running the top 800 repos suite

Details

vercel/nextjs-subscription-payments

tsconfig.json

vercel/swr

6 of 8 projects failed to build with the old tsc and were ignored

tsconfig.json

video-dev/hls.js

tsconfig.json

voideditor/void

8 of 54 projects failed to build with the old tsc and were ignored

extensions/git/tsconfig.json

build/tsconfig.build.json

weaviate/Verba

frontend/tsconfig.json

wojtekmaj/react-pdf

2 of 9 projects failed to build with the old tsc and were ignored

sample/next-app/tsconfig.json

packages/react-pdf/tsconfig.build.json

@RyanCavanaugh
Copy link
Member Author

@typescript-bot test top800

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top800 ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the top 800 repos with tsc comparing main and refs/pull/60936/merge:

Something interesting changed - please have a look.

Details

angular-ui/ui-router

1 of 5 projects failed to build with the old tsc and were ignored

test/tsconfig.json

colinhacks/zod

1 of 5 projects failed to build with the old tsc and were ignored

tsconfig.json

facebook/docusaurus

25 of 42 projects failed to build with the old tsc and were ignored

packages/create-docusaurus/tsconfig.json

gcanti/fp-ts

2 of 5 projects failed to build with the old tsc and were ignored

tsconfig.json

dtslint/tsconfig.json

getsentry/sentry-javascript

155 of 203 projects failed to build with the old tsc and were ignored

dev-packages/e2e-tests/test-applications/nextjs-turbo/tsconfig.json

gorhom/react-native-bottom-sheet

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

labring/sealos

19 of 23 projects failed to build with the old tsc and were ignored

frontend/packages/client-sdk/tsconfig.json

molefrog/wouter

packages/wouter/tsconfig.json

mui/material-ui

23 of 85 projects failed to build with the old tsc and were ignored

packages/mui-system/tsconfig.json

packages/mui-styled-engine-sc/tsconfig.json

packages/mui-styled-engine/tsconfig.json

packages/mui-material/tsconfig.json

outline/outline

tsconfig.json

umijs/umi

45 of 68 projects failed to build with the old tsc and were ignored

examples/vue-demo/tsconfig.json

@RyanCavanaugh
Copy link
Member Author

RyanCavanaugh commented Jan 10, 2025

There appears to be one bona fide bug in the whole set. Not very interesting.

https://github.com/outline/outline/blob/3c5ce8cb3d149ad8a74533ccde8c85d377dc3858/app/stores/NotificationsStore.ts#L87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants