Strip tags in placeholders #56458

ahejlsberg · 2023-11-19T01:06:51Z

This PR builds on #56434 to strip object type tags in template literal placeholders. We can merge this in case we decide to go that way.

ahejlsberg · 2023-11-19T01:08:25Z

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-11-19T01:08:28Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 5741df4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-19T01:08:28Z

Heya @ahejlsberg, I've started to run the tsc-only perf test suite on this PR at 5741df4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-19T01:08:28Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 5741df4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-19T01:08:28Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 5741df4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-19T01:21:04Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,195k (± 0.01%)}	_{295,190k (± 0.01%)}	_~	_295,139k	_295,226k	_{p=0.873 n=6}
_{Parse Time}	_{2.64s (± 0.24%)}	_{2.65s (± 0.28%)}	_~	_2.64s	_2.66s	_{p=0.081 n=6}
_{Bind Time}	_{0.82s (± 0.63%)}	_{0.83s (± 1.08%)}	_~	_0.82s	_0.84s	_{p=0.190 n=6}
_{Check Time}	_{8.05s (± 0.24%)}	_{8.05s (± 0.16%)}	_~	_8.03s	_8.06s	_{p=1.000 n=6}
_{Emit Time}	_{7.08s (± 0.32%)}	_{7.08s (± 0.42%)}	_~	_7.03s	_7.11s	_{p=0.571 n=6}
_{Total Time}	_{18.59s (± 0.20%)}	_{18.61s (± 0.24%)}	_~	_18.52s	_18.64s	_{p=0.192 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,635k (± 1.54%)}	_{191,684k (± 1.28%)}	_~	_190,651k	_196,678k	_{p=0.298 n=6}
_{Parse Time}	_{1.36s (± 0.93%)}	_{1.36s (± 0.86%)}	_~	_1.35s	_1.38s	_{p=0.801 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.18s (± 0.53%)}	_{9.19s (± 0.39%)}	_~	_9.15s	_9.23s	_{p=1.000 n=6}
_{Emit Time}	_{2.64s (± 0.62%)}	_{2.64s (± 0.20%)}	_~	_2.63s	_2.64s	_{p=0.560 n=6}
_{Total Time}	_{13.89s (± 0.35%)}	_{13.90s (± 0.24%)}	_~	_13.87s	_13.94s	_{p=0.686 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,363k (± 0.01%)}	_{347,344k (± 0.00%)}	_~	_347,326k	_347,367k	_{p=0.109 n=6}
_{Parse Time}	_{2.46s (± 0.47%)}	_{2.45s (± 0.40%)}	_~	_2.44s	_2.46s	_{p=0.209 n=6}
_{Bind Time}	_{0.92s (± 0.59%)}	_{0.92s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.640 n=6}
_{Check Time}	_{6.91s (± 0.32%)}	_{6.92s (± 0.20%)}	_~	_6.90s	_6.93s	_{p=0.934 n=6}
_{Emit Time}	_{4.05s (± 0.13%)}	_{4.04s (± 0.41%)}	_~	_4.01s	_4.06s	_{p=0.114 n=6}
_{Total Time}	_{14.35s (± 0.18%)}	_{14.33s (± 0.17%)}	_~	_14.30s	_14.37s	_{p=0.373 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,616k (± 0.00%)}	_{302,634k (± 0.01%)}	_~	_302,593k	_302,708k	_{p=0.470 n=6}
_{Parse Time}	_{2.01s (± 0.86%)}	_{1.99s (± 1.14%)}	_~	_1.95s	_2.01s	_{p=0.124 n=6}
_{Bind Time}	_{1.00s (± 1.36%)}	_{1.00s (± 1.17%)}	_~	_0.99s	_1.02s	_{p=0.550 n=6}
_{Check Time}	_{6.27s (± 0.30%)}	_{6.28s (± 0.36%)}	_~	_6.25s	_6.31s	_{p=0.746 n=6}
_{Emit Time}	_{3.59s (± 0.65%)}	_{3.57s (± 0.40%)}	_~	_3.55s	_3.59s	_{p=0.252 n=6}
_{Total Time}	_{12.87s (± 0.36%)}	_{12.83s (± 0.19%)}	_~	_12.80s	_12.86s	_{p=0.170 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,554k (± 0.00%)}	_{470,565k (± 0.00%)}	_~	_470,538k	_470,598k	_{p=0.471 n=6}
_{Parse Time}	_{2.57s (± 0.40%)}	_{2.57s (± 0.25%)}	_~	_2.56s	_2.58s	_{p=0.654 n=6}
_{Bind Time}	_{0.99s (± 0.41%)}	_{1.00s (± 0.75%)}	_{+0.01s (+ 1.01%)}	_0.99s	_1.01s	_{p=0.024 n=6}
_{Check Time}	_{16.64s (± 0.41%)}	_{16.67s (± 0.20%)}	_~	_16.61s	_16.71s	_{p=0.470 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.20s (± 0.34%)}	_{20.23s (± 0.18%)}	_~	_20.17s	_20.27s	_{p=0.422 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,805k (± 0.01%)}	_{512,797k (± 0.01%)}	_~	_512,766k	_512,839k	_{p=0.810 n=6}
_{Parse Time}	_{3.27s (± 0.23%)}	_{3.27s (± 0.27%)}	_~	_3.26s	_3.28s	_{p=0.798 n=6}
_{Bind Time}	_{1.55s (± 0.33%)}	_{1.54s (± 0.68%)}	_~	_1.53s	_1.56s	_{p=0.794 n=6}
_{Check Time}	_{2.85s (± 0.29%)}	_{2.85s (± 0.48%)}	_~	_2.83s	_2.87s	_{p=0.195 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{7.74s (± 0.13%)}	_{7.75s (± 0.13%)}	_~	_7.73s	_7.76s	_{p=0.548 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-11-19T01:23:33Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/56458/merge:

There were infrastructure failures potentially unrelated to your change:

2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L23 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2023-11-19T01:51:18Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-11-19T02:17:28Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/56458/merge:

Everything looks good!

jakebailey · 2023-11-20T20:20:01Z

Given the leak problem is not new, I personally prefer #56434 unless there's some major performance wins happening. I still need to test it (though I think you said you did?)

@typescript-bot pack this

@epmatsw Is there any chance you could try this build compared to nightly on your codebase from #52345? This is not a revert of #48044 (in that it doesn't reduce everything to string), so I'm curious as to the perf difference. Maybe if you're bored you can also try #56434 (comment)

typescript-bot · 2023-11-20T20:20:04Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 5741df4. You can monitor the build here.

typescript-bot · 2023-11-20T20:22:33Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158706/artifacts?artifactName=tgz&fileId=E6A8BCB0EF65FF921D64598A0CE099A22405C83217C5F0D64D8784C7C9564EA202&fileName=/typescript-5.4.0-insiders.20231120.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

epmatsw · 2023-11-21T15:24:17Z

@jakebailey

Doesn't seem like either has much of an effect, but it does look like something in an upcoming release did!

Version	Time (s)
5.2.2	67
5.3.2	67
5.4.0-dev.20231120	47
#56434	49
#56458	49

jakebailey · 2023-11-21T18:00:50Z

Curious; would be interesting to bisect that using something like https://www.npmjs.com/package/every-ts, e.g.:

$ every-ts bisect start
$ every-ts bisect old 5.3.2
$ every-ts bisect new 5.4.0-dev.20231120
$ every-ts tsc ...
$ every-ts bisect <old|new>
...

epmatsw · 2023-11-27T18:23:22Z

5.4.0-dev.20231107 seems to be the first "fast" version

epmatsw · 2023-11-27T18:25:24Z

Which makes sense, that has #55926

jakebailey · 2023-11-27T18:47:29Z

Oh, right. And that actually helped on your real-world case? That's good, at least, though a little suspect to be narrowing something to itself.

ahejlsberg added 8 commits November 16, 2023 09:27

Fix support for intersections in template literal placeholder types

7fa9179

Accept new baselines

f45b6dd

Update test

2cf8379

Accept new baselines

ca7e9c4

Update fourslash test

8ab01eb

Add more tests per code review

b464619

Strip object type tags in template literal placeholders

e0c3fc6

Accept new baselines

5741df4

typescript-bot assigned ahejlsberg Nov 19, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 19, 2023

ahejlsberg requested review from jakebailey and DanielRosenwasser November 19, 2023 01:07

ahejlsberg closed this Nov 21, 2023

jcalz mentioned this pull request Apr 27, 2024

Union in template literal simplifying unexpectedly #58340

Closed

Strip tags in placeholders #56458

Strip tags in placeholders #56458

Uh oh!

Conversation

ahejlsberg commented Nov 19, 2023

Uh oh!

ahejlsberg commented Nov 19, 2023

Uh oh!

typescript-bot commented Nov 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Nov 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Nov 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Nov 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Nov 19, 2023

Compiler

Uh oh!

typescript-bot commented Nov 19, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

Uh oh!

typescript-bot commented Nov 19, 2023

Uh oh!

typescript-bot commented Nov 19, 2023

Uh oh!

jakebailey commented Nov 20, 2023

Uh oh!

typescript-bot commented Nov 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Nov 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

epmatsw commented Nov 21, 2023

Uh oh!

jakebailey commented Nov 21, 2023

Uh oh!

epmatsw commented Nov 27, 2023

Uh oh!

epmatsw commented Nov 27, 2023

Uh oh!

jakebailey commented Nov 27, 2023

Uh oh!

Uh oh!

typescript-bot commented Nov 19, 2023 •

edited

Loading

typescript-bot commented Nov 19, 2023 •

edited

Loading

typescript-bot commented Nov 19, 2023 •

edited

Loading

typescript-bot commented Nov 19, 2023 •

edited

Loading

typescript-bot commented Nov 20, 2023 •

edited

Loading

typescript-bot commented Nov 20, 2023 •

edited

Loading