Skip to content

Fix issue with trailing directory separator not present if symlink wasnt detected by program #55865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

sheetalkamat
Copy link
Member

When doing path replacements we expect realpaths to be ending with directory separator so before this change, the real path that was manipulated resulted in wrong directory.

Fixes #55135

@sheetalkamat sheetalkamat marked this pull request as ready for review September 25, 2023 20:55
@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSServer forgets module type declarations, when using project references
3 participants