Always compare rest types as mutable by jakebailey · Pull Request #55793 · microsoft/TypeScript

jakebailey · 2023-09-20T04:58:52Z

...args are always safely mutable within the function body as their contents are copied. See also #53398, though this PR does not fix them inside of function bodies.

This PR ignores the mutability of rest params when relating signatures, stripping readonly-ness via getMutableArrayOrTupleType.

It's probable that this will cause a perf hit; a cache will probably fix that but I'm sending it without one for now just to test.

jakebailey · 2023-09-20T04:59:22Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-09-20T04:59:24Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at a6609d9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-20T04:59:24Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at a6609d9. You can monitor the build here.

typescript-bot · 2023-09-20T04:59:24Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at a6609d9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-20T04:59:24Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at a6609d9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-20T04:59:24Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at a6609d9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-20T05:01:27Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/157821/artifacts?artifactName=tgz&fileId=0952797A78A9CAAB929E28E81A449B883F795DF55524EE10C419E9F7BBD92EB302&fileName=/typescript-5.3.0-insiders.20230920.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-55793-6".;

typescript-bot · 2023-09-20T05:20:53Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55793/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-09-20T05:22:08Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{294,909k (± 0.01%)}	_{294,910k (± 0.01%)}	_~	_294,880k	_294,944k	_{p=0.936 n=6}
_{Parse Time}	_{2.63s (± 0.20%)}	_{2.64s (± 0.28%)}	_~	_2.63s	_2.65s	_{p=0.069 n=6}
_{Bind Time}	_{0.85s (± 0.96%)}	_{0.85s (± 0.96%)}	_~	_0.83s	_0.85s	_{p=1.000 n=6}
_{Check Time}	_{8.00s (± 0.25%)}	_{8.01s (± 0.29%)}	_~	_7.98s	_8.04s	_{p=0.288 n=6}
_{Emit Time}	_{7.01s (± 0.21%)}	_{7.02s (± 0.32%)}	_~	_7.00s	_7.06s	_{p=0.315 n=6}
_{Total Time}	_{18.48s (± 0.09%)}	_{18.53s (± 0.17%)}	_{+0.04s (+ 0.23%)}	_18.49s	_18.57s	_{p=0.019 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{191,612k (± 1.22%)}	_{194,418k (± 1.52%)}	_~	_190,598k	_196,351k	_{p=0.575 n=6}
_{Parse Time}	_{1.35s (± 0.40%)}	_{1.35s (± 1.01%)}	_~	_1.33s	_1.36s	_{p=0.341 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.12s (± 0.57%)}	_{9.07s (± 0.27%)}	_~	_9.04s	_9.11s	_{p=0.147 n=6}
_{Emit Time}	_{2.59s (± 0.40%)}	_{2.61s (± 0.80%)}	_~	_2.58s	_2.63s	_{p=0.190 n=6}
_{Total Time}	_{13.79s (± 0.39%)}	_{13.76s (± 0.36%)}	_~	_13.69s	_13.83s	_{p=0.259 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,175k (± 0.01%)}	_{347,170k (± 0.00%)}	_~	_347,155k	_347,199k	_{p=1.000 n=6}
_{Parse Time}	_{2.47s (± 0.21%)}	_{2.47s (± 0.34%)}	_~	_2.45s	_2.47s	_{p=0.923 n=6}
_{Bind Time}	_{0.94s (± 0.80%)}	_{0.94s (± 0.55%)}	_~	_0.93s	_0.94s	_{p=0.784 n=6}
_{Check Time}	_{6.89s (± 0.75%)}	_{6.85s (± 0.65%)}	_~	_6.79s	_6.92s	_{p=0.173 n=6}
_{Emit Time}	_{4.04s (± 0.26%)}	_{4.05s (± 0.49%)}	_~	_4.03s	_4.08s	_{p=0.217 n=6}
_{Total Time}	_{14.32s (± 0.30%)}	_{14.30s (± 0.31%)}	_~	_14.24s	_14.35s	_{p=0.375 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,459k (± 0.00%)}	_{302,462k (± 0.00%)}	_~	_302,451k	_302,471k	_{p=0.873 n=6}
_{Parse Time}	_{2.01s (± 0.70%)}	_{2.01s (± 0.51%)}	_~	_1.99s	_2.02s	_{p=0.738 n=6}
_{Bind Time}	_{1.00s (± 0.81%)}	_{1.00s (± 0.41%)}	_~	_0.99s	_1.00s	_{p=0.218 n=6}
_{Check Time}	_{6.22s (± 0.28%)}	_{6.23s (± 0.37%)}	_~	_6.20s	_6.26s	_{p=0.808 n=6}
_{Emit Time}	_{3.51s (± 0.35%)}	_{3.51s (± 0.59%)}	_~	_3.49s	_3.55s	_{p=0.408 n=6}
_{Total Time}	_{12.74s (± 0.20%)}	_{12.75s (± 0.37%)}	_~	_12.70s	_12.80s	_{p=0.936 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,427k (± 0.00%)}	_{470,431k (± 0.01%)}	_~	_470,385k	_470,469k	_{p=0.630 n=6}
_{Parse Time}	_{2.58s (± 0.80%)}	_{2.60s (± 0.47%)}	_~	_2.58s	_2.61s	_{p=0.370 n=6}
_{Bind Time}	_{1.00s (± 1.17%)}	_{1.00s (± 0.52%)}	_~	_0.99s	_1.00s	_{p=0.542 n=6}
_{Check Time}	_{16.57s (± 0.39%)}	_{16.63s (± 0.70%)}	_~	_16.48s	_16.75s	_{p=0.575 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.16s (± 0.24%)}	_{20.22s (± 0.55%)}	_~	_20.08s	_20.35s	_{p=0.520 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,200k (± 0.01%)}	_{512,254k (± 0.01%)}	_~	_512,182k	_512,341k	_{p=0.230 n=6}
_{Parse Time}	_{3.26s (± 0.32%)}	_{3.25s (± 0.56%)}	_~	_3.23s	_3.27s	_{p=0.142 n=6}
_{Bind Time}	_{1.54s (± 0.35%)}	_{1.55s (± 0.33%)}	_{+0.01s (+ 0.54%)}	_1.55s	_1.56s	_{p=0.038 n=6}
_{Check Time}	_{2.77s (± 0.78%)}	_{2.78s (± 0.80%)}	_~	_2.76s	_2.82s	_{p=0.669 n=6}
_{Emit Time}	_{0.08s (± 6.19%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.174 n=6}
_{Total Time}	_{7.66s (± 0.28%)}	_{7.66s (± 0.29%)}	_~	_7.62s	_7.68s	_{p=0.935 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,354ms (± 0.81%)}	_{2,366ms (± 1.48%)}	_~	_2,332ms	_2,405ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{5,363ms (± 1.28%)}	_{5,346ms (± 1.33%)}	_~	_5,270ms	_5,415ms	_{p=1.000 n=6}
_{Req 3 - references}	_{329ms (± 1.36%)}	_{329ms (± 1.67%)}	_~	_325ms	_338ms	_{p=0.871 n=6}
_{Req 4 - navto}	_{276ms (± 0.60%)}	_{276ms (± 0.77%)}	_~	_274ms	_280ms	_{p=0.622 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 7.78%)}	_{83ms (± 9.48%)}	_~	_75ms	_90ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,474ms (± 0.67%)}	_{2,462ms (± 0.70%)}	_~	_2,441ms	_2,490ms	_{p=0.336 n=6}
_{Req 2 - geterr}	_{4,105ms (± 1.75%)}	_{4,111ms (± 1.78%)}	_~	_4,052ms	_4,206ms	_{p=0.378 n=6}
_{Req 3 - references}	_{338ms (± 1.36%)}	_{337ms (± 1.42%)}	_~	_331ms	_343ms	_{p=0.684 n=6}
_{Req 4 - navto}	_{283ms (± 0.39%)}	_{283ms (± 0.32%)}	_~	_282ms	_284ms	_{p=0.932 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 7.41%)}	_{78ms (± 6.74%)}	_~	_73ms	_88ms	_{p=0.273 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,598ms (± 0.63%)}	_{2,600ms (± 0.26%)}	_~	_2,594ms	_2,613ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{1,717ms (± 0.99%)}	_{1,703ms (± 2.54%)}	_~	_1,648ms	_1,769ms	_{p=0.297 n=6}
_{Req 3 - references}	_{114ms (± 9.45%)}	_{115ms (± 8.54%)}	_~	_106ms	_128ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{367ms (± 0.56%)}	_{364ms (± 0.37%)}	_~	_363ms	_366ms	_{p=0.054 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{303ms (± 2.65%)}	_{307ms (± 2.39%)}	_~	_298ms	_317ms	_{p=0.336 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{151.89ms (± 0.18%)}	_{151.98ms (± 0.19%)}	_{+0.09ms (+ 0.06%)}	_150.88ms	_155.30ms	_{p=0.002 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.77ms (± 0.15%)}	_{226.51ms (± 0.15%)}	_{-0.26ms (- 0.12%)}	_225.28ms	_230.80ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.53ms (± 0.15%)}	_{228.44ms (± 0.15%)}	_{-0.09ms (- 0.04%)}	_226.61ms	_231.61ms	_{p=0.006 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.84ms (± 0.14%)}	_{227.88ms (± 0.16%)}	_~	_226.38ms	_233.42ms	_{p=0.558 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-20T06:18:32Z

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

jakebailey · 2023-09-20T06:26:02Z

@typescript-bot run dt

typescript-bot · 2023-09-20T06:26:05Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at a6609d9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-20T06:58:50Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55793/merge:

Everything looks good!

typescript-bot · 2023-09-20T07:50:50Z

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

jakebailey · 2023-09-20T16:49:41Z

On second thought, I think this is wrong and getMutableArrayOrTupleType works for tuples, not for arrays; it converts arrays to variadics and I mistakenly disabled that.

jakebailey · 2023-09-20T20:48:43Z

@typescript-bot run dt

typescript-bot · 2023-09-20T20:48:45Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 88cc10e. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-20T22:18:11Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

Always compare rest types as mutable

a6609d9

typescript-bot assigned jakebailey Sep 20, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 20, 2023

jakebailey requested review from gabritto and weswigham September 20, 2023 05:22

Remove unused todo

88cc10e

jakebailey marked this pull request as draft September 20, 2023 16:48

jakebailey closed this Dec 14, 2023

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Conversation

jakebailey commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Sep 20, 2023

Uh oh!

typescript-bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 20, 2023

Uh oh!

typescript-bot commented Sep 20, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Sep 20, 2023

Uh oh!

jakebailey commented Sep 20, 2023

Uh oh!

typescript-bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 20, 2023

Uh oh!

typescript-bot commented Sep 20, 2023

Uh oh!

jakebailey commented Sep 20, 2023

Uh oh!

jakebailey commented Sep 20, 2023

Uh oh!

typescript-bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jakebailey commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Sep 20, 2023 •

edited

Loading