Skip files with no-default-lib when '--skipDefaultLibCheck' are used #5511
Conversation
|
|
||
| // If the user specified '--noLib' and a file has a '/// <reference no-default-lib="true"/>', | ||
| // then we should treat that file as a default lib. | ||
| if (compilerOptions.noLib && node.hasNoDefaultLib) { |
There was a problem hiding this comment.
i do not think you need "compilerOptions.noLib" check. having a file with the NoDefaultLib comment is equivalent to --noLib.
I propose we simplify this whole thing, and remove sourceFile.isDefaultLib, as it is not clear why we have it. we should have one concept, is this file a default lib, and that is determined by the flag, the lib.d.ts we add has the flag anyways, so things should just work without the additional flag we are passing through.
we can change our test, to not include the /// comment. and just pass --noLib instead, this way it still type checks, but does not trigger this condition.
|
@DanielRosenwasser can you update please. i think this is blocking @alexeagle |
|
No, not blocking, we have a workaround (return the ES5 stdlib from CompilerHost#getDefaultLibFilename) |
|
@mhegazy check out my recent changes. |
|
👍 |
…ultLib Skip files with no-default-lib when '--skipDefaultLibCheck' and '--noLib' are used
DanielRosenwasser
changed the title
Addresses #5510.