Change default newline + turn on forceConsistentCasingInFileNames #52336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
| } | ||
|
|
||
| const newLine = getNewLineCharacter(options, () => system.newLine); | ||
| const newLine = getNewLineCharacter(options); |
Member
There was a problem hiding this comment.
I think you also need it in createCompilerHostFromProgramHost
Also if this doesnt have matching changes in services.ts, we might have issues with compileOnSave?
| }, | ||
| "version": "-18749805970-export const someString: string = \"HELLO WORLD\";\r\nexport function leftPad(s: string, n: number) { return s + n; }\r\nexport function multiply(a: number, b: number) { return a * b; }\r\n", | ||
| "signature": "-7362568283-export declare const someString: string;\nexport declare function leftPad(s: string, n: number): string;\nexport declare function multiply(a: number, b: number): number;\n" | ||
| "signature": "1874987148-export declare const someString: string;\r\nexport declare function leftPad(s: string, n: number): string;\r\nexport declare function multiply(a: number, b: number): number;\r\n" |
Member
There was a problem hiding this comment.
These now use \r\n? Isn't that the opposite of what's expected?
Member
There was a problem hiding this comment.
i think thats because 'getNewLineCharacter` doesnt have changed default?
DanielRosenwasser
requested changes
Jan 20, 2023
Member
Yeah, I think the other PR was nearly there except the printer calls needed to use the correct function (then it should have been right afterwards). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrying #52298 with a more minimal diff