Derive allCommandNames from CommandTypes enum - #52319
Merged
Jake Bailey (jakebailey) merged 1 commit intoJan 20, 2023
Merged
Conversation
Jake Bailey (jakebailey)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Sheetal Nandi (sheetalkamat)
January 20, 2023 00:33
Contributor
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping Sheetal Nandi (@sheetalkamat), Matt Bierner (@mjbvz), and Mine Starks (@minestarks) for you. Feel free to loop in other consumers/maintainers if necessary |
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Comment on lines
-22
to
-24
| /** | ||
| * Declaration module describing the TypeScript Server protocol | ||
| */ |
Member
Author
There was a problem hiding this comment.
This JSDoc comment is on the wrong declaration now that we are modules; noticed this while working on the PR.
Sheetal Nandi (sheetalkamat)
approved these changes
Jan 20, 2023
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out of #52208 (comment)