Don't show lib.d.ts line numbers in symbol baselines #5126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Not 100% sure how I feel about this change; while it is incredibly annoying, I have benefited from it when I tried some experimental stuff with re-ordering |
Contributor
|
👍 |
Contributor
|
i would hope that @DanielRosenwasser's issue is a one-time thing. |
Member
|
👍 |
RyanCavanaugh
added a commit
that referenced
this pull request
Oct 6, 2015
Don't show lib.d.ts line numbers in symbol baselines
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a ton of noise from the symbol baselines whenever we update lib.d.ts (e.g. #5123). These symbol locations aren't useful -- hide them instead so we only see useful symbol changes when making lib.d.ts updates.