Allow indexed access with known keys on otherwise deferrable indexed access on generic object#51176
Closed
Andarist wants to merge 2 commits intomicrosoft:mainfrom
Closed
Allow indexed access with known keys on otherwise deferrable indexed access on generic object#51176Andarist wants to merge 2 commits intomicrosoft:mainfrom
Andarist wants to merge 2 commits intomicrosoft:mainfrom
Conversation
…access on generic object
Andarist
commented
Oct 14, 2022
| return type; | ||
| } | ||
| if (isGenericObjectType(objectType)) { | ||
| if (isTypeAssignableTo(indexType, getImmediateIndexType(apparentObjectType, /*stringsOnly*/ false))) { |
Contributor
Author
There was a problem hiding this comment.
I don't fully expect this to be the final solution - but I think that some form of this is sound. I'm just unsure if I should avoid doing this in some situations or if there is a better way to compare the available keys on this apparentObjecType/objectType with the indexType.
Contributor
Author
|
got superseded by #53098 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #51161