Better typings for Array.concat(), etc. #33645
Conversation
jablko
force-pushed
the
patch-13
branch
5 times, most recently
from
7cf1280 to
b23d8ad
Compare
jablko
changed the title
jablko
force-pushed
the
patch-13
branch
9 times, most recently
from
684dc5d to
ee4c5e6
Compare
jablko
force-pushed
the
patch-13
branch
2 times, most recently
from
98115c4 to
a448f91
Compare
jablko
force-pushed
the
patch-13
branch
2 times, most recently
from
0e26a78 to
6b277e3
Compare
jablko
force-pushed
the
patch-13
branch
3 times, most recently
from
97d14d8 to
0faa4ed
Compare
|
@typescript-bot test this |
|
@typescript-bot test this |
jablko
force-pushed
the
patch-13
branch
3 times, most recently
from
282ee6a to
2c3101c
Compare
|
@typescript-bot test this |
|
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 0056e90. You can monitor the build here. It should now contribute to this PR's status checks. |
|
@RyanCavanaugh Thanks! Could I please trouble you to trigger @typescript-bot run dt as well? |
|
@typescript-bot run dt |
|
Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 77844cc. You can monitor the build here. It should now contribute to this PR's status checks. |
jablko
force-pushed
the
patch-13
branch
2 times, most recently
from
43679d2 to
1c95e0e
Compare
jablko
force-pushed
the
patch-13
branch
2 times, most recently
from
8efba07 to
1e82814
Compare
|
@DanielRosenwasser we should probably discuss this in a design meeting after we get an analysis of how breaky it is to user/DT/RWC tests. Though maybe we should hold this until after the existing effort to gather broken Array examples is done. |
|
Any update on this? I'm hoping it allows for idiomatic usage of eg |
|
This has been sitting for a long time, and a big part of that is the difficulty in making any change to array types. I think it has to be a single major update like #36554 nowadays. I'm going to close this PR, although it may be useful as a basis for a part of that work. |
|
The TypeScript team hasn't accepted the linked issue #19535. If you can get it accepted, this PR will have a better chance of being reviewed. |
Roll up #33606, #33620 and #33630
Fixes #19535
Fixes #24579
Fixes #26378
Fixes #26976
Fixes #29604
Fixes #31033