Fix inference to indexed access type containing substitution type #31141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
reviewed
Apr 28, 2019
src/compiler/checker.ts
Outdated
| else if (target.flags & TypeFlags.IndexedAccess && ( | ||
| (<IndexedAccessType>target).objectType.flags & TypeFlags.Substitution || | ||
| (<IndexedAccessType>target).indexType.flags & TypeFlags.Substitution)) { | ||
| target = getIndexedAccessType(getActualTypeVariable((<IndexedAccessType>target).objectType), getActualTypeVariable((<IndexedAccessType>target).indexType)); |
Member
There was a problem hiding this comment.
What about a Substitute<T[Substitute<K>]>? Substitutes can in theory nest arbitrarily, provided they keep instantiating to type variables.
Member
Author
There was a problem hiding this comment.
I've moved the logic to getActualTypeVariable and made it recurse appropriately.
weswigham
approved these changes
Apr 30, 2019
RyanCavanaugh
approved these changes
Apr 30, 2019
Contributor
|
Just tried it out - I can confirm that it's now working 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31086.