#17542 enabling forceConsistentCasingInFileNames by default #27464
Conversation
it is now on by default. See microsoft#17542
This implements microsoft#17542 enable forceConsistentCasingInFileNames by default which fixes cross-platform compatability issues due to typescript not reporting different cases as an error in windows. Making change in right repo & branch this time >_<
|
|
| "/a/b/c.ts": `/// <reference path="D.ts"/>`, | ||
| "/a/b/d.ts": "var x" | ||
| }); | ||
| test(files, { module: ModuleKind.AMD, forceConsistentCasingInFileNames: true }, "/a/b", /*useCaseSensitiveFileNames*/ false, ["c.ts", "d.ts"], [1149]); |
There was a problem hiding this comment.
In addition to this, we should have test cases when forceConsistentCasingInFileNames is set to false now that its not default.
options.forceConsistentCasingInFileNames can't be null here
sheetalkamat
left a comment
sheetalkamat
left a comment
There was a problem hiding this comment.
Given that both versions of each test behave similarly (with forceConsistentCasingInFileNames set to true and without forceConsistentCasingInFileNames value in compiler options) we need third equivalent of all test cases with forceConsistentCasingInFileNames set to false.
|
Sorry, the comments in the suggestion review didn't get properly copied to the issue. Please see the issue for more details. |
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
5 participants
This implements #17542 enable forceConsistentCasingInFileNames by default which fixes cross-platform compatability issues due to typescript not reporting different cases as an error in windows.
This is my first time modifying the typescript sourcecode, so hopefully I made the change in the right spot. I thought the PR would be a simple false -> true change in a config but apparently there's no central file for compiler option defaults.
In addition to this change the documentation at https://www.typescriptlang.org/docs/handbook/compiler-options.html would need to be updated.