🤖 User test baselines have changed#27141
Merged
sandersn merged 1 commit intomicrosoft:masterfrom Sep 17, 2018
Merged
Conversation
typescript-bot
force-pushed
the
user-update-20180801
branch
from
604a257 to
1b02d7e
Compare
sandersn
reviewed
Sep 17, 2018
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Looking good so far, but I need to look at a couple more pages of changes in chrome-devtools-frontend before merging.
| node_modules/async/dist/async.js(31,30): error TS1003: Identifier expected. | ||
| node_modules/async/dist/async.js(257,56): error TS2339: Property 'Object' does not exist on type 'Window'. | ||
| node_modules/async/dist/async.js(298,7): error TS2454: Variable 'unmasked' is used before being assigned. | ||
| node_modules/async/dist/async.js(480,35): error TS2538: Type 'true' cannot be used as an index type. |
| node_modules/debug/dist/debug.js(9,5): error TS2304: Cannot find name 'define'. | ||
| node_modules/debug/dist/debug.js(33,33): error TS2554: Expected 1 arguments, but got 2. | ||
| node_modules/debug/dist/debug.js(34,27): error TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'true | NodeRequire' has no compatible call signatures. | ||
| node_modules/debug/dist/debug.js(34,27): error TS2554: Expected 1 arguments, but got 2. |
Member
There was a problem hiding this comment.
The type changed from true | NodeRequire to false | NodeRequire. I think this must be the result of a change in the source code.
| node_modules/graceful-fs/graceful-fs.js(162,5): error TS2539: Cannot assign to 'WriteStream' because it is not a variable. | ||
| node_modules/graceful-fs/graceful-fs.js(252,3): error TS2554: Expected 0 arguments, but got 3. | ||
| node_modules/graceful-fs/graceful-fs.js(259,5): error TS2554: Expected 0 arguments, but got 3. | ||
| node_modules/graceful-fs/polyfills.js(7,24): error TS2339: Property 'env' does not exist on type 'typeof process'. |
Member
There was a problem hiding this comment.
seems like the result of the inter-file merging fix.
| @@ -1,17 +0,0 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| index.tsx(30,17): error TS7006: Parameter 'values' implicitly has an 'any' type. | |||
Member
There was a problem hiding this comment.
better contextual typing for JSX I think
Member
There was a problem hiding this comment.
Yup. Amongst other changes to fix jsx.
| node_modules/chrome-devtools-frontend/front_end/accessibility/AXBreadcrumbsPane.js(274,42): error TS2554: Expected 2 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/accessibility/AXBreadcrumbsPane.js(298,19): error TS2339: Property 'breadcrumb' does not exist on type 'Element'. | ||
| node_modules/chrome-devtools-frontend/front_end/accessibility/AXBreadcrumbsPane.js(302,23): error TS2339: Property 'tabIndex' does not exist on type 'Element'. | ||
| node_modules/chrome-devtools-frontend/front_end/accessibility/AXBreadcrumbsPane.js(314,15): error TS1110: Type expected. |
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationScreenshotPopover.js(7,11): error TS2339: Property 'AnimationScreenshotPopover' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationScreenshotPopover.js(9,23): error TS2304: Cannot find name 'Image'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationScreenshotPopover.js(18,39): error TS2322: Type 'new (width?: number, height?: number) => HTMLImageElement' is not assignable to type 'Node'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationScreenshotPopover.js(18,39): error TS2345: Argument of type 'new (width?: number, height?: number) => HTMLImageElement' is not assignable to parameter of type 'Node'. |
Member
There was a problem hiding this comment.
Fix for error message regression
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(280,5): error TS2322: Type 'Promise<void>' is not assignable to type 'Promise<undefined>'. | ||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(283,7): error TS2554: Expected 2-3 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(527,9): error TS2322: Type 'Function' is not assignable to type 'new () => any'. | ||
| Type 'Function' provides no match for the signature 'new (): any'. |
| node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(44348,15): error TS2339: Property 'keysArray' does not exist on type 'Map<any, any>'. | ||
| node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(44356,15): error TS2339: Property 'inverse' does not exist on type 'Map<any, any>'. | ||
| node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(44361,8): error TS2339: Property 'set' does not exist on type 'Multimap'. | ||
| node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(44439,17): error TS2339: Property 'get' does not exist on type 'Multimap'. |
Member
There was a problem hiding this comment.
waiting on #27096, although there are so many other changes I think I'm going to merge this baseline update anyway.
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(302,71): error TS2555: Expected at least 2 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(303,9): error TS2555: Expected at least 2 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(305,44): error TS2555: Expected at least 2 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(338,5): error TS2322: Type 'ToolbarItem' is not assignable to type '{ item(): any & any; } & { item(): any & any; }'. |
Member
There was a problem hiding this comment.
OH GOOD another duplicate error. Doesn't show up in the editor though. Strange.
Member
There was a problem hiding this comment.
Filed #27146 for the original error. Not sure why the error is duplicated now though.
sandersn
approved these changes
Sep 17, 2018
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Couple of outstanding bugs, one JSDoc parsing and the other a longstanding one that is now logging duplicates. There are enough changes that I'm going to merge this, though.
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(302,71): error TS2555: Expected at least 2 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(303,9): error TS2555: Expected at least 2 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(305,44): error TS2555: Expected at least 2 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeToolbar.js(338,5): error TS2322: Type 'ToolbarItem' is not assignable to type '{ item(): any & any; } & { item(): any & any; }'. |
Member
There was a problem hiding this comment.
Filed #27146 for the original error. Not sure why the error is duplicated now though.
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeView.js(84,7): error TS2555: Expected at least 2 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeView.js(84,34): error TS2555: Expected at least 2 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeView.js(84,63): error TS2555: Expected at least 2 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/emulation/DeviceModeView.js(103,12): error TS2339: Property '_model' does not exist on type 'typeof DeviceModeView'. |
| node_modules/chrome-devtools-frontend/front_end/ui/KeyboardShortcut.js(108,36): error TS2694: Namespace 'UI.KeyboardShortcut' has no exported member 'Descriptor'. | ||
| node_modules/chrome-devtools-frontend/front_end/ui/KeyboardShortcut.js(135,42): error TS2694: Namespace 'UI.KeyboardShortcut' has no exported member 'Key'. | ||
| node_modules/chrome-devtools-frontend/front_end/ui/KeyboardShortcut.js(144,42): error TS2694: Namespace 'UI.KeyboardShortcut' has no exported member 'Key'. | ||
| node_modules/chrome-devtools-frontend/front_end/ui/KeyboardShortcut.js(197,9): error TS1127: Invalid character. |
Member
There was a problem hiding this comment.
could be the result of the parsing changes for jsdoc tags -- #26915 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh