Handle BindingElement in fixUnusedIdentifier #23819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcasey
reviewed
May 2, 2018
| //// x; | ||
| ////} | ||
| ////{ | ||
| //// const { x, y } = o; |
There was a problem hiding this comment.
Would it be interesting to test the case where only one variable is declared and it is unused? Or is that covered by the other PR?
mhegazy
reviewed
May 3, 2018
| @@ -171,6 +171,10 @@ namespace ts.codefix { | |||
| } | |||
| break; | |||
|
|
|||
| case SyntaxKind.BindingElement: | |||
There was a problem hiding this comment.
ArrayBindingPatterens are positional, so not sure how that works with them.. can you add a test for:
var [x, y, z] = [0, 1, 2];
y;
ghost
force-pushed
the
codeFixUnusedIdentifier_destructure_partlyUnused
branch
from
e892692 to
8671615
Compare
ghost
force-pushed
the
codeFixUnusedIdentifier_destructure_partlyUnused
branch
from
8671615 to
2b47e15
Compare
mhegazy
approved these changes
May 8, 2018
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes half of #22330 -- other half fixed by #23805.