Do not suggest @types installation for relative path with extension in node_modules - #21192
Closed
Rui (xiongmao86) wants to merge 2 commits into
Closed
Rui (xiongmao86) wants to merge 2 commits into
Rui (xiongmao86) wants to merge 2 commits into
Conversation
|
|
Contributor
|
Andy (Andrewkraft) (@Andy-MS) can you please review |
Ryan Cavanaugh (RyanCavanaugh)
requested changes
Jan 17, 2018
Ryan Cavanaugh (RyanCavanaugh)
left a comment
Ryan Cavanaugh (RyanCavanaugh)
left a comment
Member
There was a problem hiding this comment.
Please don't change package-lock.json unless necessary
|
I made a PR #21241 that would allow us to report the diagnostic with a correct package name. |
|
Thanks, the error message should be correct now so no need to omit it. |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19996.