Add ValueModule as a valid object literal type, as they are immutable - #19090
Merged
Wesley Wigham (weswigham) merged 2 commits intoOct 11, 2017
Merged
Wesley Wigham (weswigham) merged 2 commits into
Wesley Wigham (weswigham) merged 2 commits into
Conversation
Wesley Wigham (weswigham)
requested review from
a user,
Ryan Cavanaugh (RyanCavanaugh) and
Mohamed Hegazy (mhegazy)
October 11, 2017 00:50
Deleted user (ghost)
approved these changes
Oct 11, 2017
| * Return true if type was inferred from an object literal, written as an object type literal, or is the shape of a module | ||
| * with no call or construct signatures. | ||
| */ | ||
| function isObjectLiteralType(type: Type) { |
There was a problem hiding this comment.
This function could use a rename
Wesley Wigham (weswigham)
deleted the
inferred-indexer-on-namespace-import
branch
October 11, 2017 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17622