Properly resolve JS-only scoped packages with defined entry points (release-2.5) #18631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks similar to #18580? |
ghost
reviewed
Sep 21, 2017
| const rest = name.slice(idx + 1); | ||
| // Scoped packages should be treated as a distinct unit | ||
| if (top[0] === '@') { | ||
| return { top: name, rest: "" }; |
There was a problem hiding this comment.
For @foo/bar/baz we want to return { top: "@foo/bar", rest: "baz" }.
|
Yep |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18630 which regressed at #18326.
When we look for a node module of the form
foo/barit's correct to look infoofor apackage.jsonbut notfoo/bar/package.json. This is not the case for@foo/bar; we do need to look for@foo/bar/package.json.Essentially any scoped package name
@foo/barneeds to be treated as if they are fully atomic, hence the change ingetNameOfTopDirectory