fix #10698: infer primitive return type in generic position#11313
Closed
HerringtonDarkholme wants to merge 1 commit intomicrosoft:masterfrom
Closed
fix #10698: infer primitive return type in generic position#11313HerringtonDarkholme wants to merge 1 commit intomicrosoft:masterfrom
HerringtonDarkholme wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Contributor
Author
|
ping @yuit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #10698 This fix only applies to primitive return type, so it guarantees no implicit any will escape the warning. It's just a mitigation for cyclic type inference, but I think it is good enough for common usage.
Some cyclic cases like
let f = () => fare not fixed, because it will need to generate more anonymous type for later merging. I don't know whether this is good.@yuit @mhegazy How do you feel about this approach?