Skip to content

Improve Array.prototype.splice typing #11222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2016
Merged

Improve Array.prototype.splice typing #11222

merged 1 commit into from
Dec 30, 2016

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Sep 28, 2016

  • There is an associated issue that is labelled
    'Bug' or 'Accepting PRs' or is in the Community milestone
  • Code is up-to-date with the master branch
  • You've successfully run jake runtests locally
  • You've signed the CLA
  • There are new or updated unit tests validating the change

Improves the typing of Array.prototype.splice so that when only passing the first two arguments with an intersection type, you do not get a confusing and useless Supplied parameters do not match any signature of call target. error.

Fixes #11205

@msftclas
Copy link

Hi @kitsonk, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@masaeedu
Copy link
Contributor

@mhegazy Could this please be merged? Keep running into #11205.

@mhegazy mhegazy closed this Dec 30, 2016
@mhegazy mhegazy reopened this Dec 30, 2016
@msftclas
Copy link

Hi @kitsonk, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@mhegazy mhegazy merged commit 9865a17 into microsoft:master Dec 30, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Dec 30, 2016

sorry for the delay.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants