Update for TS 5.6 #3221
Merged
Update for TS 5.6 #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
requested review from
DanielRosenwasser,
andrewbranch and
navya9singh
jakebailey
commented
Sep 9, 2024
There was a problem hiding this comment.
Ah, these files are now generated
| <p>Initializes a TypeScript project and creates a tsconfig.json file.</p> | ||
| </td></tr> | ||
|
|
||
| <tr class='odd' name='listFilesOnly'> | ||
| <tr class='even' name='listFilesOnly'> |
There was a problem hiding this comment.
Not in this PR but one day https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child
DanielRosenwasser
approved these changes
Sep 9, 2024
navya9singh
reviewed
Sep 9, 2024
| @@ -834,12 +840,13 @@ | |||
| "esnext.decorators", | |||
| "esnext.object", | |||
| "esnext.regexp", | |||
| "esnext.iterator", | |||
| "decorators", | |||
| "decorators.legacy" | |||
| ] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Just for my understanding, could you tell me what these pattern changes mean?
There was a problem hiding this comment.
These options are case insensitive, so this is just the absolutely ridiculous regex to verify the union of a bunch of strings
There was a problem hiding this comment.
In a better world, the regex syntax would accept syntax like (?i), but JS doesn't have that syntax, it puts it outside the regex expression and a load of consuming tools do not parse out strings like "/blah/i"
navya9singh
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had most of this change locally already while testing a 5.7 PR.