Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make elementToAppend take priority over domID for sandbox configs #2886

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

codetheweb
Copy link
Contributor

Closes #2885.

Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, though I'm assuming this is a part of a published package, in which case I'm holding off those kinds of PRs a little until I can... figure out how exactly to bump and publish these packages correctly.

@orta
Copy link
Contributor

orta commented Jul 19, 2023

Merges to v2 run pleb - which compares the versions in the package.json for any non-private package in the packages folder and then npm publishes them if that version is not present - there's a small writeup here: #130 (comment)

@jakebailey jakebailey mentioned this pull request Jul 25, 2023
4 tasks
@jakebailey
Copy link
Member

With bump versions with #2904 to minimize the waiting within the current infrastructure.

@jakebailey jakebailey merged commit 0de2a84 into microsoft:v2 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use elementToAppend when embedding sandbox
3 participants