Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes localStorage reference causing error #2796

Merged
merged 6 commits into from
Jul 25, 2023
Merged

Fixes localStorage reference causing error #2796

merged 6 commits into from
Jul 25, 2023

Conversation

ashubham
Copy link
Contributor

Fixes #2762

@ashubham
Copy link
Contributor Author

@microsoft-github-policy-service agree

@ashubham
Copy link
Contributor Author

Please review @orta

orta
orta approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good to me - thanks, you'll need to wait until someone with write access merges it though ( I'd recommend using patch-package till then)

@jakebailey
Copy link
Member

This LGTM but I'm not sure what's going on with CI. I'll try a close/reopen.

@jakebailey jakebailey closed this May 16, 2023
@jakebailey jakebailey reopened this May 16, 2023
@jakebailey
Copy link
Member

Hm, maybe it's that version bump that is failing.

@jakebailey
Copy link
Member

Fixed the lock, but, I'm unsure if we need to also start bumping reverse deps to stop multiple versions from getting pulled in due to the use of exact versions. Not sure if there's something about version bumping I'm missing in this repo.

jakebailey
jakebailey approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will merge/release this with the other PRs that require package publishes.

@orta
Copy link
Contributor

orta commented Jul 25, 2023 •
edited
Loading

There's a script

TypeScript-Website/.github/workflows/CI.yml

Line 25 in 36c79ce

- run: node test/verifyPackageVersions.js
which will sync verify the internal references are consistent ( and update them to be afterwards)

@jakebailey jakebailey mentioned this pull request Jul 25, 2023
Merged
4 tasks
@jakebailey
Copy link
Member

With bump versions with #2904 to minimize the waiting within the current infrastructure.

@jakebailey jakebailey merged commit c620f50 into microsoft:v2 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta orta approved these changes

@jakebailey jakebailey jakebailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typescript-vfs still accesses local storage even when storer is provided
3 participants
@ashubham @jakebailey @orta