This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Document wildcard module declarations #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
| } | ||
| ``` | ||
|
|
||
| Imports of the kind "*!text" and "json!*" can now be used. |
There was a problem hiding this comment.
I would (1) change to active voice (2) be more explicit about the type of "*!text"/"json!*" ('imports of the kind' sounds vague to me). Something like:
Now you can import things that match
"*!text"and"json!*".
Also you should backtick-quote "*!text" and "json!*" because the stars seem to be parsed as italic right now.
|
👍 |
|
I think this belongs with Modules rather than in Module Resolution.. thoughts? |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #308